third_party/WebKit/Source/core/paint/ReplacedPainter.cpp - Issue 1584903002: Improvement handling of background and outline paint phases

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/ReplacedPainter.cpp

Issue 1584903002: Improvement handling of background and outline paint phases (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@PaintPhaseRename

Patch Set: Fix TablePainter and TableRowPainter Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/paint/PaintPhase.h ('K') | « third_party/WebKit/Source/core/paint/PartPainter.cpp ('k') | third_party/WebKit/Source/core/paint/SVGContainerPainter.cpp » ('j') | third_party/WebKit/Source/core/paint/TableSectionPainter.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/ReplacedPainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/ReplacedPainter.cpp b/third_party/WebKit/Source/core/paint/ReplacedPainter.cpp

index c8b5db2714403acdbcc31f598b831b2810a97c79..c718f642847a9f13a1fcc0554607cc4b0fa843d1 100644

--- a/third_party/WebKit/Source/core/paint/ReplacedPainter.cpp

+++ b/third_party/WebKit/Source/core/paint/ReplacedPainter.cpp

@@ -41,9 +41,8 @@ void ReplacedPainter::paint(const PaintInfo& paintInfo, const LayoutPoint& paint

if (paintInfo.phase == PaintPhaseClippingMask && (!m_layoutReplaced.hasLayer() || !m_layoutReplaced.layer()->hasCompositedClippingMask()))

return;

- if (paintInfo.phase == PaintPhaseOutline || paintInfo.phase == PaintPhaseSelfOutline) {

- if (m_layoutReplaced.styleRef().outlineWidth())

- ObjectPainter(m_layoutReplaced).paintOutline(paintInfo, adjustedPaintOffset);

+ if (shouldPaintSelfOutline(paintInfo.phase)) {

+ ObjectPainter(m_layoutReplaced).paintOutline(paintInfo, adjustedPaintOffset);

return;

}