Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2908)

Unified Diff: base/BUILD.gn

Issue 1584893002: Allow base to depend on allocator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move is_nacl condition to allocator group Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/allocator/BUILD.gn » ('j') | base/base.gyp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/BUILD.gn
diff --git a/base/BUILD.gn b/base/BUILD.gn
index 17fa1ce7ceb96ed0f495a3e5143621cdef5fe97e..9aaa7d4e68e79ccaf219e731c2bc6ac42a52b028 100644
--- a/base/BUILD.gn
+++ b/base/BUILD.gn
@@ -951,6 +951,7 @@ component("base") {
]
deps = [
+ "//base/allocator",
"//base/third_party/dynamic_annotations",
"//third_party/modp_b64",
]
@@ -1858,7 +1859,6 @@ test("base_unittests") {
":message_loop_tests",
":prefs",
":prefs_test_support",
- "//base/allocator",
"//base/test:run_all_unittests",
"//base/test:test_support",
"//base/third_party/dynamic_annotations",
@@ -1867,6 +1867,9 @@ test("base_unittests") {
"//third_party/icu",
]
+ # Some unittests depend on the ALLOCATOR_SHIM macro.
+ configs += [ "//base/allocator:allocator_shim_define" ]
+
data = [
"test/data/",
]
« no previous file with comments | « no previous file | base/allocator/BUILD.gn » ('j') | base/base.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698