Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 1584883002: Fix PepperPortAllocatorSession to initialize callback_factory_. (Closed)

Created:
4 years, 11 months ago by Sergey Ulanov
Modified:
4 years, 11 months ago
Reviewers:
Jamie, kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix PepperPortAllocatorSession to initialize callback_factory_. After crrev.com/368701 PepperPortAllocatorSession constructor wasn't initializing calllback_factory_ properly, so the plugin was crashing. BUG=576985 Committed: https://crrev.com/4f5bacb7eaade57cc8f6164478f026519adb6907 Cr-Commit-Position: refs/heads/master@{#369245}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M remoting/client/plugin/pepper_port_allocator.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Sergey Ulanov
4 years, 11 months ago (2016-01-13 18:06:37 UTC) #2
Jamie
lgtm
4 years, 11 months ago (2016-01-13 18:13:04 UTC) #4
kelvinp
lgtm
4 years, 11 months ago (2016-01-13 18:41:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1584883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1584883002/1
4 years, 11 months ago (2016-01-13 19:07:33 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-13 19:53:31 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-13 19:54:22 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f5bacb7eaade57cc8f6164478f026519adb6907
Cr-Commit-Position: refs/heads/master@{#369245}

Powered by Google App Engine
This is Rietveld 408576698