test/unittests/compiler/interpreter-assembler-unittest.cc - Issue 1584813002: [Interpreter] Make ForInPrepare take a kRegTriple8 and ForInNext take kRegPair8 for cache state

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/unittests/compiler/interpreter-assembler-unittest.cc

Issue 1584813002: [Interpreter] Make ForInPrepare take a kRegTriple8 and ForInNext take kRegPair8 for cache state (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@int_forin

Patch Set: Fix release Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « test/cctest/interpreter/test-bytecode-generator.cc ('k') | test/unittests/interpreter/bytecode-array-builder-unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: test/unittests/compiler/interpreter-assembler-unittest.cc

diff --git a/test/unittests/compiler/interpreter-assembler-unittest.cc b/test/unittests/compiler/interpreter-assembler-unittest.cc

index f57ca05b3f16630d96fe6f620c4910f13fdb67ad..44c6a1a4680ea69b985b3e1b039f8113c74fbd94 100644

--- a/test/unittests/compiler/interpreter-assembler-unittest.cc

+++ b/test/unittests/compiler/interpreter-assembler-unittest.cc

@@ -351,6 +351,7 @@ TARGET_TEST_F(InterpreterAssemblerTest, BytecodeOperand) {

case interpreter::OperandType::kMaybeReg8:

case interpreter::OperandType::kReg8:

case interpreter::OperandType::kRegPair8:

+ case interpreter::OperandType::kRegTriple8:

EXPECT_THAT(m.BytecodeOperandReg(i),

m.IsBytecodeOperandSignExtended(offset));

break;