test/unittests/interpreter/bytecode-array-builder-unittest.cc - Issue 1584813002: [Interpreter] Make ForInPrepare take a kRegTriple8 and ForInNext take kRegPair8 for cache state

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/unittests/interpreter/bytecode-array-builder-unittest.cc

Issue 1584813002: [Interpreter] Make ForInPrepare take a kRegTriple8 and ForInNext take kRegPair8 for cache state (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@int_forin

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/unittests/interpreter/bytecode-array-builder-unittest.cc

diff --git a/test/unittests/interpreter/bytecode-array-builder-unittest.cc b/test/unittests/interpreter/bytecode-array-builder-unittest.cc

index 504a05c21d3afddbe05b8a1d28e4ebc3330db397..7ec51f4ef8c5422fa771c76798b74f1bc4775652 100644

--- a/test/unittests/interpreter/bytecode-array-builder-unittest.cc

+++ b/test/unittests/interpreter/bytecode-array-builder-unittest.cc

@@ -208,9 +208,9 @@ TEST_F(BytecodeArrayBuilderTest, AllBytecodesGenerated) {

.Throw()

.Bind(&after_throw);

- builder.ForInPrepare(reg, reg, reg)

+ builder.ForInPrepare(reg)

.ForInDone(reg, reg)

- .ForInNext(reg, reg, reg, reg)

+ .ForInNext(reg, reg, reg)

.ForInStep(reg);

// Wide constant pool loads

« src/interpreter/interpreter.cc ('K') | « test/unittests/compiler/interpreter-assembler-unittest.cc ('k') | no next file » | no next file with comments »