Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1653)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/cctest/interpreter/test-bytecode-generator.cc

Issue 1584813002: [Interpreter] Make ForInPrepare take a kRegTriple8 and ForInNext take kRegPair8 for cache state (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@int_forin
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/interpreter/interpreter.cc ('K') | « src/interpreter/interpreter.cc ('k') | test/unittests/compiler/interpreter-assembler-unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/interpreter/test-bytecode-generator.cc
diff --git a/test/cctest/interpreter/test-bytecode-generator.cc b/test/cctest/interpreter/test-bytecode-generator.cc
index f2763558afa054f2fd384d24e6a8a4a8c1e1b8c9..fa4c8f801544909f4518d1fbb88de74bb40d6691 100644
--- a/test/cctest/interpreter/test-bytecode-generator.cc
+++ b/test/cctest/interpreter/test-bytecode-generator.cc
@@ -4904,30 +4904,30 @@ TEST(ForIn) {
"for (var p in x) { return p; }",
8 * kPointerSize,
1,
- 45,
+ 42,
{
- B(LdaConstant), U8(0), //
- B(Star), R(1), //
- B(JumpIfUndefined), U8(39), //
- B(JumpIfNull), U8(37), //
- B(ToObject), //
- B(JumpIfNull), U8(34), //
- B(Star), R(3), //
- B(ForInPrepare), R(4), R(5), R(6), //
- B(LdaZero), //
- B(Star), R(7), //
- B(ForInDone), R(7), R(6), //
- B(JumpIfTrue), U8(20), //
- B(ForInNext), R(3), R(4), R(5), R(7), //
- B(JumpIfUndefined), U8(7), //
- B(Star), R(0), //
- B(Star), R(2), //
- B(Return), //
- B(ForInStep), R(7), //
- B(Star), R(7), //
- B(Jump), U8(-21), //
- B(LdaUndefined), //
- B(Return), //
+ B(LdaConstant), U8(0), //
+ B(Star), R(1), //
+ B(JumpIfUndefined), U8(36), //
+ B(JumpIfNull), U8(34), //
+ B(ToObject), //
+ B(JumpIfNull), U8(31), //
+ B(Star), R(3), //
+ B(ForInPrepare), R(4), //
+ B(LdaZero), //
+ B(Star), R(7), //
+ B(ForInDone), R(7), R(6), //
+ B(JumpIfTrue), U8(19), //
+ B(ForInNext), R(3), R(7), R(4), //
+ B(JumpIfUndefined), U8(7), //
+ B(Star), R(0), //
+ B(Star), R(2), //
+ B(Return), //
+ B(ForInStep), R(7), //
+ B(Star), R(7), //
+ B(Jump), U8(-20), //
+ B(LdaUndefined), //
+ B(Return), //
},
1,
{InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}},
@@ -4935,22 +4935,22 @@ TEST(ForIn) {
"for (var p in [1,2,3]) { x += p; }",
8 * kPointerSize,
1,
- 51,
+ 48,
{
B(LdaZero), //
B(Star), R(1), //
B(CreateArrayLiteral), U8(0), U8(0), U8(3), //
- B(JumpIfUndefined), U8(42), //
- B(JumpIfNull), U8(40), //
- B(ToObject), //
+ B(JumpIfUndefined), U8(39), //
B(JumpIfNull), U8(37), //
+ B(ToObject), //
+ B(JumpIfNull), U8(34), //
B(Star), R(3), //
- B(ForInPrepare), R(4), R(5), R(6), //
+ B(ForInPrepare), R(4), //
B(LdaZero), //
B(Star), R(7), //
B(ForInDone), R(7), R(6), //
- B(JumpIfTrue), U8(23), //
- B(ForInNext), R(3), R(4), R(5), R(7), //
+ B(JumpIfTrue), U8(22), //
+ B(ForInNext), R(3), R(7), R(4), //
B(JumpIfUndefined), U8(10), //
B(Star), R(0), //
B(Star), R(2), //
@@ -4958,7 +4958,7 @@ TEST(ForIn) {
B(Star), R(1), //
B(ForInStep), R(7), //
B(Star), R(7), //
- B(Jump), U8(-24), //
+ B(Jump), U8(-23), //
B(LdaUndefined), //
B(Return), //
},
@@ -4971,22 +4971,22 @@ TEST(ForIn) {
"}",
7 * kPointerSize,
1,
- 80,
+ 77,
{
B(CreateObjectLiteral), U8(0), U8(0), U8(deep_elements_flags), //
B(Star), R(0), //
B(CreateArrayLiteral), U8(1), U8(1), U8(simple_flags), //
- B(JumpIfUndefined), U8(68), //
- B(JumpIfNull), U8(66), //
- B(ToObject), //
+ B(JumpIfUndefined), U8(65), //
B(JumpIfNull), U8(63), //
+ B(ToObject), //
+ B(JumpIfNull), U8(60), //
B(Star), R(1), //
- B(ForInPrepare), R(2), R(3), R(4), //
+ B(ForInPrepare), R(2), //
B(LdaZero), //
B(Star), R(5), //
B(ForInDone), R(5), R(4), //
- B(JumpIfTrue), U8(49), //
- B(ForInNext), R(1), R(2), R(3), R(5), //
+ B(JumpIfTrue), U8(48), //
+ B(ForInNext), R(1), R(5), R(2), //
B(JumpIfUndefined), U8(36), //
B(Star), R(6), //
B(StoreICSloppy), R(0), U8(2), U8(vector->GetIndex(slot4)), //
@@ -5004,7 +5004,7 @@ TEST(ForIn) {
B(Jump), U8(8), //
B(ForInStep), R(5), //
B(Star), R(5), //
- B(Jump), U8(-50), //
+ B(Jump), U8(-49), //
B(LdaUndefined), //
B(Return), //
},
@@ -5015,22 +5015,22 @@ TEST(ForIn) {
"for (x[0] in [1,2,3]) { return x[3]; }",
8 * kPointerSize,
1,
- 63,
+ 60,
{
B(CreateArrayLiteral), U8(0), U8(0), U8(simple_flags), //
B(Star), R(0), //
B(CreateArrayLiteral), U8(1), U8(1), U8(simple_flags), //
- B(JumpIfUndefined), U8(51), //
- B(JumpIfNull), U8(49), //
- B(ToObject), //
+ B(JumpIfUndefined), U8(48), //
B(JumpIfNull), U8(46), //
+ B(ToObject), //
+ B(JumpIfNull), U8(43), //
B(Star), R(1), //
- B(ForInPrepare), R(2), R(3), R(4), //
+ B(ForInPrepare), R(2), //
B(LdaZero), //
B(Star), R(5), //
B(ForInDone), R(5), R(4), //
- B(JumpIfTrue), U8(32), //
- B(ForInNext), R(1), R(2), R(3), R(5), //
+ B(JumpIfTrue), U8(31), //
+ B(ForInNext), R(1), R(5), R(2), //
B(JumpIfUndefined), U8(19), //
B(Star), R(6), //
B(LdaZero), //
@@ -5042,7 +5042,7 @@ TEST(ForIn) {
B(Return), //
B(ForInStep), R(5), //
B(Star), R(5), //
- B(Jump), U8(-33), //
+ B(Jump), U8(-32), //
B(LdaUndefined), //
B(Return), //
},
« src/interpreter/interpreter.cc ('K') | « src/interpreter/interpreter.cc ('k') | test/unittests/compiler/interpreter-assembler-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698