Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 15848010: Fix ReturnValue::Set. (Closed)

Created:
7 years, 6 months ago by marja
Modified:
7 years, 6 months ago
Reviewers:
dcarney, Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Make ReturnValue a friend of Persistent, so it can use operator*. BUG= R=dcarney@chromium.org, svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14999

Patch Set 1 #

Patch Set 2 : friend instead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M include/v8.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
marja
dcarney@, ptal. I was under the impression that v8 is already post-handlepocalyptic, but doesn't seem ...
7 years, 6 months ago (2013-06-06 15:07:39 UTC) #1
dcarney
On 2013/06/06 15:07:39, marja wrote: > dcarney@, ptal. I was under the impression that v8 ...
7 years, 6 months ago (2013-06-06 18:09:59 UTC) #2
marja
alright, made it a friend instead
7 years, 6 months ago (2013-06-07 09:58:41 UTC) #3
dcarney
lgtm
7 years, 6 months ago (2013-06-07 10:39:45 UTC) #4
marja
svenpanne@, ptal
7 years, 6 months ago (2013-06-07 10:41:22 UTC) #5
Sven Panne
lgtm
7 years, 6 months ago (2013-06-07 10:42:54 UTC) #6
dcarney
7 years, 6 months ago (2013-06-07 10:46:57 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r14999 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698