Cleanup: Remove ScopedGenericObj. Use scoped_ptr<type, CustomDeleter> instead.

Cleanup: Remove ScopedGenericObj. Use scoped_ptr<type, CustomDeleter> instead.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202828

[Lei Zhang, 2013-05-28 20:42:47]

ccameron: ui/
kbr: ui/gl/ OWNERS
mark: base/ OWNERS

I have a couple other CLs out to remove the other few usages of
ScopedGenericObj.

[ccameron, 2013-05-28 20:45:51]

ui/ lgtm

[Mark Mentovai, 2013-05-28 20:52:17]

LGTM

https://codereview.chromium.org/15848005/diff/7001/base/mac/mac_util.mm
File base/mac/mac_util.mm (right):

https://codereview.chromium.org/15848005/diff/7001/base/mac/mac_util.mm#newco...
base/mac/mac_util.mm:656: return return_string;
Since you’ve rewritten this function to always return return_string, I’d flip
the condition around and give it only one return point at the bottom.

  if (platform_expert) {
    // do stuff, maybe set return_string
  }
  return return_string;

[Lei Zhang, 2013-05-28 21:01:18]

https://codereview.chromium.org/15848005/diff/7001/base/mac/mac_util.mm
File base/mac/mac_util.mm (right):

https://codereview.chromium.org/15848005/diff/7001/base/mac/mac_util.mm#newco...
base/mac/mac_util.mm:656: return return_string;
On 2013/05/28 20:52:18, Mark Mentovai wrote:
> Since you’ve rewritten this function to always return return_string, I’d flip
> the condition around and give it only one return point at the bottom.
> 
>   if (platform_expert) {
>     // do stuff, maybe set return_string
>   }
>   return return_string;

Done.

[Mark Mentovai, 2013-05-28 21:04:29]

LGTM. Check the trybot, though!

[Ken Russell (switch to Gerrit), 2013-05-28 21:22:02]

LGTM

Thanks for the cleanup.

[commit-bot: I haz the power, 2013-05-29 03:10:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/15848005/16001

[commit-bot: I haz the power, 2013-05-29 03:56:05]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[commit-bot: I haz the power, 2013-05-29 05:50:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/15848005/16001

[commit-bot: I haz the power, 2013-05-29 06:22:01]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-05-29 07:48:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/15848005/16001

[commit-bot: I haz the power, 2013-05-29 08:51:54]

Change committed as 202828