Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 1584783002: Revert of net: build fix about CertificateList (Closed)

Created:
4 years, 11 months ago by dshwang
Modified:
4 years, 11 months ago
Reviewers:
pauljensen
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of net: build fix about CertificateList (patchset #1 id:1 of https://codereview.chromium.org/1572253002/ ) Reason for revert: This issue is known in crbug.com/506663 and we want to fix c++ spec and clang rather than making chromium code silly. Nico asked to revert it. Original issue's description: > net: build fix about CertificateList > > clang complains it doesn't initialize const member, so this CL calls the > default constructor explicitly. > > ../../net/cert/multi_threaded_cert_verifier.cc:430:25: error: default initialization of an object of const type 'const CertificateList' (aka 'const vector<scoped_refptr<net::X509Certificate> >') without a user-provided default constructor > const CertificateList empty_cert_list; > ^ > 1 error generated. > > Committed: https://crrev.com/18937ad93812903be37e75f60510ed258c4117e1 > Cr-Commit-Position: refs/heads/master@{#368585} TBR=pauljensen@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Committed: https://crrev.com/b02fdc10897628f8000c761f91cb57cff593abab Cr-Commit-Position: refs/heads/master@{#369131}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/cert/multi_threaded_cert_verifier.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
dshwang
Created Revert of net: build fix about CertificateList
4 years, 11 months ago (2016-01-13 09:36:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1584783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1584783002/1
4 years, 11 months ago (2016-01-13 09:36:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1584783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1584783002/1
4 years, 11 months ago (2016-01-13 10:03:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1584783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1584783002/1
4 years, 11 months ago (2016-01-13 10:33:25 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-13 10:54:39 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-13 10:56:11 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b02fdc10897628f8000c761f91cb57cff593abab
Cr-Commit-Position: refs/heads/master@{#369131}

Powered by Google App Engine
This is Rietveld 408576698