Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 1584763002: Call FOR_EACH_OBSERVER after setting error handler. (Closed)

Created:
4 years, 11 months ago by hidehiko
Modified:
4 years, 11 months ago
CC:
chromium-reviews, kinaba
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Call FOR_EACH_OBSERVER after setting error handler. Conceptually, the observers should be called after the mojo's error handler setting. BUG=n/a TEST=Ran trybots. Committed: https://crrev.com/bc92feb7b46ebf6dcc62af8757b782578f79333b Cr-Commit-Position: refs/heads/master@{#369312}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M components/arc/arc_bridge_service.cc View 9 chunks +11 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
hidehiko
PTAL.
4 years, 11 months ago (2016-01-13 08:04:28 UTC) #2
Luis Héctor Chávez
lgtm Thanks for doing this
4 years, 11 months ago (2016-01-13 21:12:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1584763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1584763002/1
4 years, 11 months ago (2016-01-13 21:14:43 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
4 years, 11 months ago (2016-01-13 23:23:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1584763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1584763002/1
4 years, 11 months ago (2016-01-14 02:40:15 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-14 03:42:48 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 03:45:19 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bc92feb7b46ebf6dcc62af8757b782578f79333b
Cr-Commit-Position: refs/heads/master@{#369312}

Powered by Google App Engine
This is Rietveld 408576698