Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Unified Diff: components/omnibox/browser/omnibox_field_trial.cc

Issue 1584733003: [Cleanup] Remove some expired omnibox field trials. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Only remove the dynamic trials Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/omnibox/browser/omnibox_field_trial.cc
diff --git a/components/omnibox/browser/omnibox_field_trial.cc b/components/omnibox/browser/omnibox_field_trial.cc
index 3dd7f4e746e775ec1e8772535a57ba1aec0ea452..5639a13596e43bddbcf504e1a518b6882f2a7b7f 100644
--- a/components/omnibox/browser/omnibox_field_trial.cc
+++ b/components/omnibox/browser/omnibox_field_trial.cc
@@ -32,20 +32,6 @@ typedef HUPScoringParams::ScoreBuckets ScoreBuckets;
// Field trial names.
const char kStopTimerFieldTrialName[] = "OmniboxStopTimer";
-// The autocomplete dynamic field trial name prefix. Each field trial is
-// configured dynamically and is retrieved automatically by Chrome during
-// the startup.
-const char kAutocompleteDynamicFieldTrialPrefix[] = "AutocompleteDynamicTrial_";
-// The maximum number of the autocomplete dynamic field trials (aka layers).
-const int kMaxAutocompleteDynamicFieldTrials = 5;
-
-
-// Concatenates the autocomplete dynamic field trial prefix with a field trial
-// ID to form a complete autocomplete field trial name.
-std::string DynamicFieldTrialName(int id) {
- return base::StringPrintf("%s%d", kAutocompleteDynamicFieldTrialPrefix, id);
-}
-
void InitializeBucketsFromString(const std::string& bucket_string,
ScoreBuckets* score_buckets) {
// Clear the buckets.
@@ -123,13 +109,6 @@ double HUPScoringParams::ScoreBuckets::HalfLifeTimeDecay(
return pow(2.0, -half_life_intervals);
}
-void OmniboxFieldTrial::ActivateDynamicTrials() {
- // Initialize all autocomplete dynamic field trials. This method may be
- // called multiple times.
- for (int i = 0; i < kMaxAutocompleteDynamicFieldTrials; ++i)
- base::FieldTrialList::FindValue(DynamicFieldTrialName(i));
-}
-
int OmniboxFieldTrial::GetDisabledProviderTypes() {
const std::string& types_string = variations::GetVariationParamValue(
kBundledExperimentFieldTrialName,
@@ -144,11 +123,6 @@ int OmniboxFieldTrial::GetDisabledProviderTypes() {
void OmniboxFieldTrial::GetActiveSuggestFieldTrialHashes(
std::vector<uint32_t>* field_trial_hashes) {
field_trial_hashes->clear();
- for (int i = 0; i < kMaxAutocompleteDynamicFieldTrials; ++i) {
- const std::string& trial_name = DynamicFieldTrialName(i);
- if (base::FieldTrialList::TrialExists(trial_name))
- field_trial_hashes->push_back(metrics::HashName(trial_name));
- }
if (base::FieldTrialList::TrialExists(kBundledExperimentFieldTrialName)) {
field_trial_hashes->push_back(
metrics::HashName(kBundledExperimentFieldTrialName));

Powered by Google App Engine
This is Rietveld 408576698