Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: chrome/browser/autocomplete/search_provider_unittest.cc

Issue 1584733003: [Cleanup] Remove some expired omnibox field trials. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix a unit test Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chrome_browser_field_trials.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autocomplete/search_provider_unittest.cc
diff --git a/chrome/browser/autocomplete/search_provider_unittest.cc b/chrome/browser/autocomplete/search_provider_unittest.cc
index 256c1366eb36b123e6e00fd704c5342004e8872e..32fecdab6af18a47520df6e554ff941a6e89af03 100644
--- a/chrome/browser/autocomplete/search_provider_unittest.cc
+++ b/chrome/browser/autocomplete/search_provider_unittest.cc
@@ -549,10 +549,8 @@ void SearchProviderTest::ResetFieldTrialList() {
field_trial_list_.reset(new base::FieldTrialList(
new metrics::SHA1EntropyProvider("foo")));
variations::testing::ClearAllVariationParams();
- base::FieldTrial* trial = base::FieldTrialList::CreateFieldTrial(
- "AutocompleteDynamicTrial_0", "DefaultGroup");
- trial->group();
}
+
base::FieldTrial* SearchProviderTest::CreateFieldTrial(
const char* field_trial_rule,
bool enabled) {
@@ -2550,6 +2548,10 @@ TEST_F(SearchProviderTest, DefaultProviderSuggestRelevanceScoringUrlInput) {
// A basic test that verifies the field trial triggered parsing logic.
TEST_F(SearchProviderTest, FieldTrialTriggeredParsing) {
+ base::FieldTrial* trial = base::FieldTrialList::CreateFieldTrial(
+ OmniboxFieldTrial::kBundledExperimentFieldTrialName, "DefaultGroup");
+ trial->group();
+
QueryForInputAndWaitForFetcherResponses(
ASCIIToUTF16("foo"), false,
"[\"foo\",[\"foo bar\"],[\"\"],[],"
« no previous file with comments | « no previous file | chrome/browser/chrome_browser_field_trials.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698