components/omnibox/browser/autocomplete_controller.cc - Issue 1584733003: [Cleanup] Remove some expired omnibox field trials.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/omnibox/browser/autocomplete_controller.cc

Issue 1584733003: [Cleanup] Remove some expired omnibox field trials. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chrome_browser_field_trials.cc ('k') | components/omnibox/browser/base_search_provider.cc » ('j') | components/omnibox/browser/base_search_provider.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/omnibox/browser/autocomplete_controller.cc

diff --git a/components/omnibox/browser/autocomplete_controller.cc b/components/omnibox/browser/autocomplete_controller.cc

index df7990d9d3a932a1a58398f4c651963aad3c98f7..6a59938a7244cc9bd4ea15946b8a154316c6c283 100644

--- a/components/omnibox/browser/autocomplete_controller.cc

+++ b/components/omnibox/browser/autocomplete_controller.cc

@@ -177,7 +177,7 @@ AutocompleteController::AutocompleteController(

keyword_provider_(NULL),

search_provider_(NULL),

zero_suggest_provider_(NULL),

- stop_timer_duration_(OmniboxFieldTrial::StopTimerFieldTrialDuration()),

+ stop_timer_duration_(base::TimeDelta::FromMilliseconds(1500)),

Mark P 2016/01/14 05:31:02 I wouldn't be surprised if we decide to experiment

Ilya Sherman 2016/01/14 05:40:41 I'd argue that it's easy enough to restore, but I

done_(true),

in_start_(false),

template_url_service_(provider_client_->GetTemplateURLService()) {