Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 1584713004: Merge to XFA: Use _GLIBCXX_DEBUG in standalone Debug builds on Linux. (Closed)

Created:
4 years, 11 months ago by Lei Zhang
Modified:
4 years, 11 months ago
Reviewers:
Oliver Chang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Use _GLIBCXX_DEBUG in standalone Debug builds on Linux. TBR=ochang@chromium.org Review URL: https://codereview.chromium.org/1588643003 . (cherry picked from commit 783709f76baf7893b7334209fe89d947acd6369d) Committed: https://pdfium.googlesource.com/pdfium/+/f2663fecb894d447dfc9b4b04b4477eca5b557b7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M build/standalone.gypi View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Lei Zhang
TBR, clean merge, all tests pass locally.
4 years, 11 months ago (2016-01-14 03:01:16 UTC) #1
Lei Zhang
Committed patchset #1 (id:1) manually as f2663fecb894d447dfc9b4b04b4477eca5b557b7 (presubmit successful).
4 years, 11 months ago (2016-01-14 03:01:32 UTC) #3
Oliver Chang
4 years, 11 months ago (2016-01-14 03:23:24 UTC) #4
Message was sent while issue was closed.
On 2016/01/14 03:01:32, Lei Zhang wrote:
> Committed patchset #1 (id:1) manually as
> f2663fecb894d447dfc9b4b04b4477eca5b557b7 (presubmit successful).

lgtm

Powered by Google App Engine
This is Rietveld 408576698