Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(282)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: tests/compiler/dart2js/cps_ir/expected/control_flow_1.js
Issue
1584693003
:
dart2js cps: for(;;) is shorter than while(true) (Closed)
Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set:
Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
pkg/compiler/lib/src/js_backend/codegen/codegen.dart
tests/compiler/dart2js/cps_ir/expected/control_flow_1.js
tests/compiler/dart2js/cps_ir/expected/control_flow_2.js
tests/compiler/dart2js/cps_ir/expected/control_flow_3.js
View unified diff
|
Download patch
« no previous file with comments
|
« pkg/compiler/lib/src/js_backend/codegen/codegen.dart
('k') |
tests/compiler/dart2js/cps_ir/expected/control_flow_2.js »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 // Expectation for test:
1 // Expectation for test:
2 // main() {
2 // main() {
3 // while (true);
3 // while (true);
4 // }
4 // }
5
5
6 function() {
6 function() {
7
while
(
true
)
7
for
(
;;
)
8 ;
8 ;
9 }
9 }
OLD
NEW
« no previous file with comments
|
« pkg/compiler/lib/src/js_backend/codegen/codegen.dart
('k') |
tests/compiler/dart2js/cps_ir/expected/control_flow_2.js »
('j') |
no next file with comments »
Issue 1584693003: dart2js cps: for(;;) is shorter than while(true) (Closed)
Created 4 years, 11 months ago by sra1
Modified 4 years, 11 months ago
Reviewers: asgerf
Base URL: https://github.com/dart-lang/sdk.git@master
Comments: 0
This is Rietveld
408576698