Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issue 1584693003: dart2js cps: for(;;) is shorter than while(true) (Closed)

Created:
4 years, 11 months ago by sra1
Modified:
4 years, 11 months ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : baseline #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M pkg/compiler/lib/src/js_backend/codegen/codegen.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/cps_ir/expected/control_flow_1.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/cps_ir/expected/control_flow_2.js View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/cps_ir/expected/control_flow_3.js View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
sra1
4 years, 11 months ago (2016-01-13 04:35:24 UTC) #2
asgerf
4 years, 11 months ago (2016-01-13 17:05:42 UTC) #4
asgerf
lgtm
4 years, 11 months ago (2016-01-13 17:05:47 UTC) #5
sra1
Committed patchset #1 (id:1) manually as dbb96bac3241b2bc0fb66699d6e43625af431d4f (presubmit successful).
4 years, 11 months ago (2016-01-13 18:25:52 UTC) #7
sra1
4 years, 11 months ago (2016-01-13 20:57:24 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
9db58343b33a30f35b3a0086c26dcaa261bfe15c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698