third_party/WebKit/LayoutTests/fast/forms/text/text-font-height-mismatch.html - Issue 1584683002: INPUT text field: Fix a chopped editing text issue.

Side by Side Diff: third_party/WebKit/LayoutTests/fast/forms/text/text-font-height-mismatch.html

Issue 1584683002: INPUT text field: Fix a chopped editing text issue. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/fast/forms/input-textarea-padding-match-expected.html ('K') | « third_party/WebKit/LayoutTests/fast/forms/input-textarea-padding-match-expected.html ('k') | third_party/WebKit/LayoutTests/platform/mac/fast/forms/search/search-vertical-alignment-expected.png » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <meta charset="utf-8">	2 <meta charset="utf-8">

3 <style>	3 <style>

4 @font-face {	4 @font-face {

5 font-family: NotoSansCJK;	5 font-family: NotoSansCJK;

6 src: url("../../../third_party/NotoSansCJK/NotoSansCJKjp-Regular-cid03075.ot f") format("opentype");	6 src: url("../../../third_party/NotoSansCJK/NotoSansCJKjp-Regular-cid03075.ot f") format("opentype");

7 }	7 }

8 </style>	8 </style>

9 <p>Editable text should be centered vertically.</p>	9 <p>Editable text should be centered vertically.</p>

10 <div id="webfont"><input style="font-family:NotoSansCJK;"value="ABCgjy"></div>	10 <div id="webfont"><input style="font-family:NotoSansCJK;"value="ABCgjy"></div>

11 <div><input style="border: solid 1px black; line-height:16px; height:24px; font- size:24px;" value="ABCgjy"></div>	11 <div><input style="border: solid 1px black; line-height:16px; height:24px; font- size:24px;" value="ABCgjy"></div>

12	12

13 <!-- crbug.com/539858 -->	13 <!-- crbug.com/539858 -->

14 <div><input style="font-size:100%; height:22px; line-height: 1px;" value="ABCgjy "></div>	14 <div><input style="font-size:100%; height:22px; line-height: 1px;" value="ABCgjy "></div>

15 <script>	15 <script>

16 if (window.testRunner)	16 if (window.testRunner)

17 testRunner.waitUntilDone();	17 testRunner.waitUntilDone();

18	18

19 document.fonts.ready.then(function() {	19 document.fonts.ready.then(function() {

20 document.getElementById('webfont').innerHTML = '<input style="border:' +	20 document.getElementById('webfont').innerHTML = '<input style="border:' +

21 'solid 1px black; font-size:16px; font-family:NotoSansCJK;"' +	21 'solid 1px black; font-size:16px; font-family:NotoSansCJK;"' +

	22 'value="ふ ABCgjy">' +
	Julien - ping for review 2016/01/14 16:46:18 In the new output, the value from this first <inpu In the new output, the value from this first <input> is now clipped. I am assuming that this is expected as it is shifted a bit lower than before the change. tkent 2016/01/15 02:09:49 As for this INPUT, I think no pixel differences. Show quoted text On 2016/01/14 at 16:46:18, Julien - leaving Blink Jan 18 wrote: > In the new output, the value from this first <input> is now clipped. I am assuming that this is expected as it is shifted a bit lower than before the change. As for this INPUT, I think no pixel differences. The clipped text in the third INPUT is an expected behavior change because we clip text by content box.
	23 '<input style="border: solid 1px black; font-size:16px; ' +

	24 'line-height:17px; height:24px; font-family:NotoSansCJK;"' +

22 'value="ふ ABCgjy">';	25 'value="ふ ABCgjy">';

	26 // The first INPUT is for crbug.com/519331.

	27 // The second INPUT is for crbug.com/576589.

23 if (window.testRunner)	28 if (window.testRunner)

24 testRunner.notifyDone();	29 testRunner.notifyDone();

25 });	30 });

26 </script>	31 </script>

OLD	NEW