third_party/WebKit/LayoutTests/fast/forms/input-textarea-padding-match-expected.html - Issue 1584683002: INPUT text field: Fix a chopped editing text issue.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/forms/input-textarea-padding-match-expected.html

Issue 1584683002: INPUT text field: Fix a chopped editing text issue. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/forms/input-textarea-padding-match.html ('k') | third_party/WebKit/LayoutTests/fast/forms/text/text-font-height-mismatch.html » ('j') | third_party/WebKit/LayoutTests/fast/forms/text/text-font-height-mismatch.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <body>	3 <body>

4 <p>This test ensures padding inside input and textarea elements match.</p>	4 <p>This test ensures padding inside input and textarea elements match.</p>

5 <style type="text/css">	5 <style type="text/css">

6 textarea {	6 textarea {

7 display: block;	7 display: block;

8 font-family: arial,sans-serif;	8 font-family: arial,sans-serif;

	9 font-size: 0px;
	Julien - ping for review 2016/01/14 16:46:18 Why do we need those changes? Why do we need those changes? tkent 2016/01/15 02:09:49 This test doesn't work with the LayoutTextControlS Show quoted text On 2016/01/14 at 16:46:18, Julien - leaving Blink Jan 18 wrote: > Why do we need those changes? This test doesn't work with the LayoutTextControlSIngleLine change because we change the behavior in a case of font-size is taller than the INPUT height (align at the top vs. centering). The purpose of this test is to ensure identical text position in INPUT and TEXTAREA. So, font-size:0px was a wrong fix. I should remove 'height' property of the INPUT instead.
9 border: none;	10 border: none;

10 padding: 0 0 0 10px;	11 padding: 0 0 0 10px;

11 margin: 0;	12 margin: 0;

12 resize: none;	13 resize: none;

13 width: 20px;	14 width: 20px;

14 height: 10px;	15 height: 10px;

15 overflow: hidden;	16 overflow: hidden;

16 }	17 }

17 </style>	18 </style>

18 <textarea>\|</textarea>	19 <textarea>\|</textarea>

19 </body>	20 </body>

20 </html>	21 </html>

OLD	NEW