Add EmbedderSdk to EmbedderUriResolver

Add EmbedderSdk to EmbedderUriResolver

R=brianwilkerson@google.com, johnmccutchan@google.com, pquitslund@google.com

Committed: https://github.com/dart-lang/sdk/commit/ebd1736c58d6d249e13eacf926c7136ea52f5105

[danrubel, 2016-01-14 13:56:15]

danrubel@google.com changed reviewers:
+ brianwilkerson@google.com, pquitslund@google.com

[Brian Wilkerson, 2016-01-14 16:47:18]

LGTM

https://codereview.chromium.org/1584663006/diff/1/pkg/analyzer/lib/source/emb...
File pkg/analyzer/lib/source/embedder.dart (right):

https://codereview.chromium.org/1584663006/diff/1/pkg/analyzer/lib/source/emb...
pkg/analyzer/lib/source/embedder.dart:22: const String _DART_COLON_PREFIX =
'dart:';
nit: Personally, I dislike top-level declarations other than classes and
typedefs. Is there a reason this couldn't remain a static field?

nit: Don't we already have this constant defined somewhere?

[pquitslund, 2016-01-14 17:22:47]

LGTM!

[Cutch, 2016-01-14 17:32:40]

johnmccutchan@google.com changed reviewers:
+ johnmccutchan@google.com

[Cutch, 2016-01-14 17:32:41]

LGTM

Thanks!

[danrubel, 2016-01-14 19:51:45]

Description was changed from

==========
Add EmbedderSdk to EmbedderUriResolver
==========

to

==========
Add EmbedderSdk to EmbedderUriResolver

R=brianwilkerson@google.com, johnmccutchan@google.com, pquitslund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ebd1736c58d6d249e13eacf926c7136ea52f5105
==========

[danrubel, 2016-01-14 19:51:46]

Committed patchset #2 (id:20001) manually as
ebd1736c58d6d249e13eacf926c7136ea52f5105 (presubmit successful).