Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1584653011: third_party/wayland: Add wayland_client target to wayland.gyp (Closed)

Created:
4 years, 11 months ago by Michael Forney
Modified:
4 years, 11 months ago
Reviewers:
reveman, piman
CC:
chromium-reviews, rjkroege, spang
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

third_party/wayland: Add wayland_client and wayland_protocol targets to wayland.gyp This matches the targets present in BUILD.gn. BUG=578890 Committed: https://crrev.com/1624ad1b62af5efad5454dd604f7fab5bd7f67ea Cr-Commit-Position: refs/heads/master@{#370307}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add wayland_protocol target #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -3 lines) Patch
M third_party/wayland/wayland.gyp View 1 3 chunks +51 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
Michael Forney
Hi, This adds a wayland_client target for gyp so that it can be used in ...
4 years, 11 months ago (2016-01-16 03:00:35 UTC) #3
piman
Sending to reveman@ who is more familiar with the library.
4 years, 11 months ago (2016-01-19 22:14:07 UTC) #6
reveman
https://codereview.chromium.org/1584653011/diff/1/third_party/wayland/wayland.gyp File third_party/wayland/wayland.gyp (right): https://codereview.chromium.org/1584653011/diff/1/third_party/wayland/wayland.gyp#newcode83 third_party/wayland/wayland.gyp:83: 'protocol/wayland-protocol.c', Can we add a wayland_protocol target for this ...
4 years, 11 months ago (2016-01-19 22:23:30 UTC) #7
Michael Forney
On 2016/01/19 22:23:30, reveman wrote: > https://codereview.chromium.org/1584653011/diff/1/third_party/wayland/wayland.gyp > File third_party/wayland/wayland.gyp (right): > > https://codereview.chromium.org/1584653011/diff/1/third_party/wayland/wayland.gyp#newcode83 > ...
4 years, 11 months ago (2016-01-19 23:15:01 UTC) #8
reveman
lgtm
4 years, 11 months ago (2016-01-20 00:29:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1584653011/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1584653011/40001
4 years, 11 months ago (2016-01-20 01:09:04 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 11 months ago (2016-01-20 05:10:49 UTC) #19
commit-bot: I haz the power
4 years, 11 months ago (2016-01-20 05:11:59 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1624ad1b62af5efad5454dd604f7fab5bd7f67ea
Cr-Commit-Position: refs/heads/master@{#370307}

Powered by Google App Engine
This is Rietveld 408576698