|
|
Created:
4 years, 11 months ago by Michael Forney Modified:
4 years, 11 months ago CC:
chromium-reviews, rjkroege, spang Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionthird_party/wayland: Add wayland_client and wayland_protocol targets to wayland.gyp
This matches the targets present in BUILD.gn.
BUG=578890
Committed: https://crrev.com/1624ad1b62af5efad5454dd604f7fab5bd7f67ea
Cr-Commit-Position: refs/heads/master@{#370307}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Add wayland_protocol target #Messages
Total messages: 21 (13 generated)
Patchset #2 (id:20001) has been deleted
forney@google.com changed reviewers: + piman@chromium.org
Hi, This adds a wayland_client target for gyp so that it can be used in a wayland ozone implementation.
Description was changed from ========== third_party/wayland: Add wayland_client target to wayland.gyp This matches the wayland_client present in BUILD.gn. BUG= ========== to ========== third_party/wayland: Add wayland_client target to wayland.gyp This matches the wayland_client present in BUILD.gn. BUG=578890 ==========
piman@chromium.org changed reviewers: + reveman@chromium.org
Sending to reveman@ who is more familiar with the library.
https://codereview.chromium.org/1584653011/diff/1/third_party/wayland/wayland... File third_party/wayland/wayland.gyp (right): https://codereview.chromium.org/1584653011/diff/1/third_party/wayland/wayland... third_party/wayland/wayland.gyp:83: 'protocol/wayland-protocol.c', Can we add a wayland_protocol target for this to match BUILD.gn?
On 2016/01/19 22:23:30, reveman wrote: > https://codereview.chromium.org/1584653011/diff/1/third_party/wayland/wayland... > File third_party/wayland/wayland.gyp (right): > > https://codereview.chromium.org/1584653011/diff/1/third_party/wayland/wayland... > third_party/wayland/wayland.gyp:83: 'protocol/wayland-protocol.c', > Can we add a wayland_protocol target for this to match BUILD.gn? Done. I wasn't quite sure about the direct_dependent_settings and include_dirs for wayland_protocols, but since wayland_server and wayland_protocols have the same public_configs in BUILD.gn, I just use the settings from wayland_server.
Description was changed from ========== third_party/wayland: Add wayland_client target to wayland.gyp This matches the wayland_client present in BUILD.gn. BUG=578890 ========== to ========== third_party/wayland: Add wayland_client and wayland_protocol targets to wayland.gyp This matches the targets present in BUILD.gn. BUG=578890 ==========
lgtm
The CQ bit was checked by forney@google.com
The CQ bit was unchecked by forney@google.com
The CQ bit was checked by forney@google.com
The CQ bit was unchecked by forney@google.com
The CQ bit was checked by forney@google.com
The CQ bit was unchecked by forney@google.com
The CQ bit was checked by forney@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1584653011/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1584653011/40001
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== third_party/wayland: Add wayland_client and wayland_protocol targets to wayland.gyp This matches the targets present in BUILD.gn. BUG=578890 ========== to ========== third_party/wayland: Add wayland_client and wayland_protocol targets to wayland.gyp This matches the targets present in BUILD.gn. BUG=578890 Committed: https://crrev.com/1624ad1b62af5efad5454dd604f7fab5bd7f67ea Cr-Commit-Position: refs/heads/master@{#370307} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/1624ad1b62af5efad5454dd604f7fab5bd7f67ea Cr-Commit-Position: refs/heads/master@{#370307} |