content/browser/service_worker/service_worker_version.h - Issue 1584653009: Change RunAfterStartWorker to not start the worker if it is already running.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_version.h

Issue 1584653009: Change RunAfterStartWorker to not start the worker if it is already running. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix race condition if worker is already running Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/navigator_connect/navigator_connect_context_impl.cc ('k') | content/browser/service_worker/service_worker_version.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_version.h

diff --git a/content/browser/service_worker/service_worker_version.h b/content/browser/service_worker/service_worker_version.h

index 96c54453043cc695265eb67c440b6f02a2f8f172..2b7009d48d6e57f74dcb814e85136822c1270c88 100644

--- a/content/browser/service_worker/service_worker_version.h

+++ b/content/browser/service_worker/service_worker_version.h

@@ -178,8 +178,10 @@ class CONTENT_EXPORT ServiceWorkerVersion

// Starts the worker if it isn't already running, and calls |task| when the

// worker is running, or |error_callback| if starting the worker failed.

- void RunAfterStartWorker(const StatusCallback& error_callback,

- const base::Closure& task);

+ // If the worker is already running, |task| is executed synchronously (before

+ // this method returns).

+ void RunAfterStartWorker(const base::Closure& task,

+ const StatusCallback& error_callback);

// Call this while the worker is running before dispatching an event to the

// worker. This informs ServiceWorkerVersion about the event in progress.