content/browser/geofencing/geofencing_manager.cc - Issue 1584653009: Change RunAfterStartWorker to not start the worker if it is already running.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/geofencing/geofencing_manager.cc

Issue 1584653009: Change RunAfterStartWorker to not start the worker if it is already running. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix race condition if worker is already running Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/background_sync/background_sync_manager.cc ('k') | content/browser/navigator_connect/navigator_connect_context_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/geofencing/geofencing_manager.cc

diff --git a/content/browser/geofencing/geofencing_manager.cc b/content/browser/geofencing/geofencing_manager.cc

index 1fce30f3b4d5feb049d4049d7bb3404af6a4aff8..ca53d46bf0b68a90f45c376435ce9910b93bf653 100644

--- a/content/browser/geofencing/geofencing_manager.cc

+++ b/content/browser/geofencing/geofencing_manager.cc

@@ -395,11 +395,11 @@ void GeofencingManager::DeliverGeofencingEvent(

// until the callback dies. Otherwise the registration could be released when

// this method returns - before the event is delivered to the service worker.

active_version->RunAfterStartWorker(

- base::Bind(&GeofencingManager::OnEventError, this),

base::Bind(&GeofencingManager::DeliverEventToRunningWorker, this,

service_worker_registration, event_type,

registration->region_id, registration->region,

- make_scoped_refptr(active_version)));

+ make_scoped_refptr(active_version)),

+ base::Bind(&GeofencingManager::OnEventError, this));

}

void GeofencingManager::DeliverEventToRunningWorker(