Optimize Websocket compression for no context takeover requests

Optimize Websocket compression for no context takeover requests

Resolve issue with server applying context takeover when not enabled.

After resolving negotiation and optimizing client/server takeover usage
an bug became apparent where no context takeover was being applied but
not advertised by the server.

This patch resolves that issue and adds tests to validate in the future.

Ensure encoders/decoders are properly 'discarded' when client_no_context_takeover
and server_no_context_takeover flags are detected.

Resolve issues with client not sending appropriate header request values based
on the configured passed by CompressionOptions.

Add tests for client header values

BUG=25317
Patch by Matthew Butler <butler.matthew@gmail.com>;

R=sgjesse@google.com

Committed: https://github.com/dart-lang/sdk/commit/9240052ebb59111bdcb58ed06b4a878347b8932f

[butlermatt, 2016-01-15 20:55:14]

butler.matthew@gmail.com changed reviewers:
+ sgjesse@google.com

[butlermatt, 2016-01-15 20:55:15]

Per comments in CL: https://codereview.chromium.org/1583933007/ I have created
another patch 
https://codereview.chromium.org/1584653008/

This patch addresses 3 areas:
* Optimize client and server side no take over handling to discard encoder and
decoders appropriate.
* Resolves an issue where client would not request headers based on the provided
CompressionOptions at creation (and adds tests)
* Resolves an issue where server was enabling 'no context takeover' yet did not
advertise it in a response and was not configured in CompressionOptions. (And
adds tests)

Verified all green for websocket compression in Autobahn in 4 tests:
* Server without "no context takeover" options enabled.
* Server with "no context takeover" options enabled.
* Client without "no context takeover" options enabled.
* Client with "no context takeover" options enabled.

[Søren Gjesse, 2016-01-18 07:36:00]

LGTM, thanks

https://codereview.chromium.org/1584653008/diff/1/tests/standalone/io/web_soc...
File tests/standalone/io/web_socket_compression_test.dart (right):

https://codereview.chromium.org/1584653008/diff/1/tests/standalone/io/web_soc...
tests/standalone/io/web_socket_compression_test.dart:253: websocket.add('Hello
World');
With the different options of context take-over and discarding of encoders and
decoders I think testing sending of several messages would be beneficial. Please
make a separate change to extend the test.

[Søren Gjesse, 2016-01-18 07:51:27]

Description was changed from

==========
Optimize Websocket compression for no context takeover requests

Resolve issue with server applying context takeover when not enabled.

After resolving negotiation and optimizing client/server takeover usage
an bug became apparent where no context takeover was being applied but
not advertised by the server.

This patch resolves that issue and adds tests to validate in the future.

Ensure encoders/decoders are properly 'discarded' when
client_no_context_takeover
and server_no_context_takeover flags are detected.

Resolve issues with client not sending appropriate header request values based
on the configured passed by CompressionOptions.

Add tests for client header values

BUG=25317
==========

to

==========
Optimize Websocket compression for no context takeover requests

Resolve issue with server applying context takeover when not enabled.

After resolving negotiation and optimizing client/server takeover usage
an bug became apparent where no context takeover was being applied but
not advertised by the server.

This patch resolves that issue and adds tests to validate in the future.

Ensure encoders/decoders are properly 'discarded' when
client_no_context_takeover
and server_no_context_takeover flags are detected.

Resolve issues with client not sending appropriate header request values based
on the configured passed by CompressionOptions.

Add tests for client header values

BUG=25317

Patch by Matthew Butler <butler.matthew@gmail.com>
==========

[Søren Gjesse, 2016-01-18 07:51:56]

Description was changed from

==========
Optimize Websocket compression for no context takeover requests

Resolve issue with server applying context takeover when not enabled.

After resolving negotiation and optimizing client/server takeover usage
an bug became apparent where no context takeover was being applied but
not advertised by the server.

This patch resolves that issue and adds tests to validate in the future.

Ensure encoders/decoders are properly 'discarded' when
client_no_context_takeover
and server_no_context_takeover flags are detected.

Resolve issues with client not sending appropriate header request values based
on the configured passed by CompressionOptions.

Add tests for client header values

BUG=25317

Patch by Matthew Butler <butler.matthew@gmail.com>
==========

to

==========
Optimize Websocket compression for no context takeover requests

Resolve issue with server applying context takeover when not enabled.

After resolving negotiation and optimizing client/server takeover usage
an bug became apparent where no context takeover was being applied but
not advertised by the server.

This patch resolves that issue and adds tests to validate in the future.

Ensure encoders/decoders are properly 'discarded' when
client_no_context_takeover
and server_no_context_takeover flags are detected.

Resolve issues with client not sending appropriate header request values based
on the configured passed by CompressionOptions.

Add tests for client header values

BUG=25317

Patch by Matthew Butler <butler.matthew@gmail.com>

R=sgjesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9240052ebb59111bdcb58ed06b4a878347b8932f
==========

[Søren Gjesse, 2016-01-18 07:51:58]

Committed patchset #1 (id:1) manually as
9240052ebb59111bdcb58ed06b4a878347b8932f (presubmit successful).