Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 1584653007: Issue 25504. Fix for ignoring expression bodies in incremental resolver. (Closed)

Created:
4 years, 11 months ago by scheglov
Modified:
4 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -6 lines) Patch
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 1 chunk +10 lines, -6 lines 0 comments Download
M pkg/analyzer/test/generated/incremental_resolver_test.dart View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 11 months ago (2016-01-15 20:14:53 UTC) #1
Brian Wilkerson
LGTM
4 years, 11 months ago (2016-01-15 20:17:26 UTC) #2
scheglov
4 years, 11 months ago (2016-01-15 20:20:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6b56451788612c49b34f0e85f316a4b037c51f7c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698