Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 15846014: Added support for EXT_frag_depth (Closed)

Created:
7 years, 7 months ago by bajones
Modified:
7 years, 6 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, apatrick_chromium
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed gman's feedback #

Total comments: 1

Patch Set 3 : ANGLE DEPS roll 2245:2249 #

Total comments: 1

Patch Set 4 : Added flag to chrome_restart_request.cc #

Patch Set 5 : Rebasing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -16 lines) Patch
M DEPS View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/feature_info.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 1 2 2 chunks +7 lines, -1 line 0 comments Download
M gpu/command_buffer/service/feature_info_unittest.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 3 7 chunks +32 lines, -12 lines 0 comments Download
M gpu/command_buffer/service/shader_translator.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
bajones
Will require an ANGLE roll before it can land, in the process of landing the ...
7 years, 7 months ago (2013-05-24 18:08:39 UTC) #1
Zhenyao Mo
On 2013/05/24 18:08:39, bajones wrote: > Will require an ANGLE roll before it can land, ...
7 years, 6 months ago (2013-05-28 18:14:58 UTC) #2
greggman
a couple of things then lgtm https://codereview.chromium.org/15846014/diff/1/gpu/command_buffer/service/feature_info.cc File gpu/command_buffer/service/feature_info.cc (right): https://codereview.chromium.org/15846014/diff/1/gpu/command_buffer/service/feature_info.cc#newcode700 gpu/command_buffer/service/feature_info.cc:700: AddExtensionString("GL_EXT_frag_depth"); needs feature_flags_.ext_frag_depth ...
7 years, 6 months ago (2013-05-28 18:17:58 UTC) #3
Ken Russell (switch to Gerrit)
LGTM with gman's feedback addressed. https://codereview.chromium.org/15846014/diff/4002/content/public/common/content_switches.cc File content/public/common/content_switches.cc (right): https://codereview.chromium.org/15846014/diff/4002/content/public/common/content_switches.cc#newcode845 content/public/common/content_switches.cc:845: // Enabled WebGL extensions ...
7 years, 6 months ago (2013-05-29 15:16:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bajones@chromium.org/15846014/9001
7 years, 6 months ago (2013-06-02 22:38:12 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=6323
7 years, 6 months ago (2013-06-02 22:47:17 UTC) #6
bajones
Need LGTM from joi@ for content/public and an owner of content/renderer
7 years, 6 months ago (2013-06-03 16:43:08 UTC) #7
piman
One thing, after that LGTM. https://codereview.chromium.org/15846014/diff/9001/content/public/common/content_switches.h File content/public/common/content_switches.h (right): https://codereview.chromium.org/15846014/diff/9001/content/public/common/content_switches.h#newcode267 content/public/common/content_switches.h:267: CONTENT_EXPORT extern const char ...
7 years, 6 months ago (2013-06-03 18:06:47 UTC) #8
jam
you added me but piman reviewed already, so removing myself
7 years, 6 months ago (2013-06-03 20:29:46 UTC) #9
Jói
Removed myself as well, piman@'s review is sufficient for //content.
7 years, 6 months ago (2013-06-03 21:27:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bajones@chromium.org/15846014/20001
7 years, 6 months ago (2013-06-03 21:31:33 UTC) #11
bajones
7 years, 6 months ago (2013-06-04 03:33:53 UTC) #12
Message was sent while issue was closed.
Committed patchset #5 manually as r203825 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698