Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 15846008: DevTools: update CM to TOT version 3.13+ (6edd771495) (Closed)

Created:
7 years, 7 months ago by lushnikov
Modified:
7 years, 7 months ago
Reviewers:
vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: update CM to TOT version 3.13+ (6edd771495) The Tip-of-tree CodeMirror has fix to the behaviour of beforeChange event which is important for autocompletion. BUG=167290 R=vsevik@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151107

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -136 lines) Patch
M Source/devtools/front_end/cm/codemirror.css View 4 chunks +7 lines, -4 lines 0 comments Download
M Source/devtools/front_end/cm/codemirror.js View 40 chunks +191 lines, -132 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
lushnikov
Please take a look
7 years, 7 months ago (2013-05-24 15:28:48 UTC) #1
vsevik
lgtm
7 years, 7 months ago (2013-05-24 15:31:28 UTC) #2
lushnikov
7 years, 7 months ago (2013-05-24 15:48:18 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r151107 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698