Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5716)

Unified Diff: chrome/common/extensions/api/experimental_system_info_storage.idl

Issue 15846002: Rename 'harddisk' to 'fixed' for storage unit type (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/experimental_system_info_storage.idl
diff --git a/chrome/common/extensions/api/experimental_system_info_storage.idl b/chrome/common/extensions/api/experimental_system_info_storage.idl
index ea533aa182d87081ecca9afb8e6223a6c11a9362..d20c2e0ff0b851b0a5f6a96719bae3bf4b9b162c 100644
--- a/chrome/common/extensions/api/experimental_system_info_storage.idl
+++ b/chrome/common/extensions/api/experimental_system_info_storage.idl
@@ -5,19 +5,18 @@
namespace experimental.systemInfo.storage {
enum StorageUnitType {
- // Unknow storage type.
- unknown,
- // Hard disk.
- harddisk,
- // Removable storage, e.g.USB device.
- removable
+ // The storage has a fixed media, e.g. hard disk or flash drive.
vandebo (ex-Chrome) 2013/05/23 15:49:44 nit: The storage has fixed media, i.e. hard disk o
Hongbo Min 2013/05/24 01:03:14 Done.
+ fixed,
+ // The storage has a removable media, e.g. USB mass storage.
vandebo (ex-Chrome) 2013/05/23 15:49:44 nit: The storage is removable, i.e. USB flash driv
Hongbo Min 2013/05/24 01:03:14 Done.
+ removable,
+ // The storage has an unknown storage media type.
vandebo (ex-Chrome) 2013/05/23 15:49:44 nit: The storage type is unknown.
Hongbo Min 2013/05/24 01:03:14 Done.
+ unknown
};
dictionary StorageUnitInfo {
// The unique id of the storage unit.
DOMString id;
- // The type of storage device. The value is one of the constants defined
- // for this type.
+ // The media type of the storage unit.
StorageUnitType type;
// The total amount of the storage space, in bytes.
double capacity;

Powered by Google App Engine
This is Rietveld 408576698