Remove --no-sandbox flag from command line for telemetry

Remove --no-sandbox flag from command line for telemetry

Now that the browser is able to dump for child processes the
--no-sandbox flag is not required for getting memory statistics. So,
this is removed form the telemetry benchmarks.

BUG=461788
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:win_perf_bisect

Committed: https://crrev.com/2bf18cfdfa1b8b0bd829edea2d90277e7e5b0b71
Cr-Commit-Position: refs/heads/master@{#372667}

[ssid, 2016-01-13 13:50:49]

Description was changed from

==========
Remove --no-sandbox flag from command line for telemetry

Now that the browser is able to dump for child processes the
--no-sandbox flag is not required for getting memory statistics. So,
this is removed form the telemetry benchmarks. In future it might be
required for android when secomp sandbox is introduced on android.

BUG=461788
==========

to

==========
Remove --no-sandbox flag from command line for telemetry

Now that the browser is able to dump for child processes the
--no-sandbox flag is not required for getting memory statistics. So,
this is removed form the telemetry benchmarks. In future it might be
required for android when secomp sandbox is introduced on android.

BUG=461788
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect
==========

[ssid, 2016-01-14 18:47:28]

ssid@chromium.org changed reviewers:
+ primiano@chromium.org

[ssid, 2016-01-14 18:47:28]

If the sandbox fix is stable then this can land. The reference to the bug is
still there in the log message in dump_manager.cc. But I think i will leave it
there for now since it will become true once the android seccomp is enabled.
there is another referecne to the bug in clear_refs file. I don't think there is
a solution to that issue.

[ssid, 2016-01-14 18:47:49]

Description was changed from

==========
Remove --no-sandbox flag from command line for telemetry

Now that the browser is able to dump for child processes the
--no-sandbox flag is not required for getting memory statistics. So,
this is removed form the telemetry benchmarks. In future it might be
required for android when secomp sandbox is introduced on android.

BUG=461788
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect
==========

to

==========
Remove --no-sandbox flag from command line for telemetry

Now that the browser is able to dump for child processes the
--no-sandbox flag is not required for getting memory statistics. So,
this is removed form the telemetry benchmarks. In future it might be
required for android when seccomp sandbox is introduced on android.

BUG=461788
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect
==========

[Primiano Tucci (use gerrit), 2016-01-19 17:58:24]

LGTM once the other dependencies get unblocked.
Also I think you want to remove the comment about Android, as you tried and
seems to work.

[ssid, 2016-01-20 19:07:36]

Description was changed from

==========
Remove --no-sandbox flag from command line for telemetry

Now that the browser is able to dump for child processes the
--no-sandbox flag is not required for getting memory statistics. So,
this is removed form the telemetry benchmarks. In future it might be
required for android when seccomp sandbox is introduced on android.

BUG=461788
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect
==========

to

==========
Remove --no-sandbox flag from command line for telemetry

Now that the browser is able to dump for child processes the
--no-sandbox flag is not required for getting memory statistics. So,
this is removed form the telemetry benchmarks.

BUG=461788
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect
==========

[ssid, 2016-01-20 19:20:50]

I made few more changes. Just realized android is not an issue anymore. ptal.

[ssid, 2016-01-20 19:21:07]

The CQ bit was checked by ssid@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-20 19:23:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1584583003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1584583003/20001

[commit-bot: I haz the power, 2016-01-20 21:50:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-20 21:50:30]

Dry run: This issue passed the CQ dry run.

[ssid, 2016-01-21 11:51:55]

ssid@chromium.org changed reviewers:
+ nednguyen@google.com

[ssid, 2016-01-21 11:51:55]

+ned ptal thanks.

[ssid, 2016-01-21 11:52:49]

Description was changed from

==========
Remove --no-sandbox flag from command line for telemetry

Now that the browser is able to dump for child processes the
--no-sandbox flag is not required for getting memory statistics. So,
this is removed form the telemetry benchmarks.

BUG=461788
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect
==========

to

==========
Remove --no-sandbox flag from command line for telemetry

Now that the browser is able to dump for child processes the
--no-sandbox flag is not required for getting memory statistics. So,
this is removed form the telemetry benchmarks.

BUG=461788
TBR=oysteine@chromium.org
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect
==========

[nednguyen, 2016-01-21 14:24:05]

lgtm

[nednguyen, 2016-01-21 14:24:37]

On 2016/01/21 14:24:05, nednguyen wrote:
> lgtm

Hmhh, actually does this make the benchmark with reference browser fail?

[Primiano Tucci (use gerrit), 2016-01-21 16:57:10]

On 2016/01/21 14:24:37, nednguyen wrote:
> On 2016/01/21 14:24:05, nednguyen wrote:
> > lgtm
> 
> Hmhh, actually does this make the benchmark with reference browser fail?

Good point. ssid can you check if any of the benchmarks that use memory-infra
have a reference build?
I am pretty sure memory.top_10_mobile doesn't. Not sure about the other ones.

[Primiano Tucci (use gerrit), 2016-01-21 16:58:52]

worst case we could stay conservative and turn that into a todo.
I think that memory_infra.py should be fine, check the blink benchmark

https://codereview.chromium.org/1584583003/diff/20001/components/tracing/docs...
File components/tracing/docs/memory_infra.md (left):

https://codereview.chromium.org/1584583003/diff/20001/components/tracing/docs...
components/tracing/docs/memory_infra.md:22: 4. For now, some subsystems only
work if Chrome is started with the
I think you want to keep this for a while, as ppl will still need for the
current stable / beta

[ssid, 2016-01-25 14:43:15]

Description was changed from

==========
Remove --no-sandbox flag from command line for telemetry

Now that the browser is able to dump for child processes the
--no-sandbox flag is not required for getting memory statistics. So,
this is removed form the telemetry benchmarks.

BUG=461788
TBR=oysteine@chromium.org
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect
==========

to

==========
Remove --no-sandbox flag from command line for telemetry

Now that the browser is able to dump for child processes the
--no-sandbox flag is not required for getting memory statistics. So,
this is removed form the telemetry benchmarks.

BUG=461788
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect
==========

[ssid, 2016-01-25 14:44:53]

There are no reference build runs for any of the affected benchmarks. It is
disabled because memory-infra is relatively new. So, this flag can be removed.

https://codereview.chromium.org/1584583003/diff/20001/components/tracing/docs...
File components/tracing/docs/memory_infra.md (left):

https://codereview.chromium.org/1584583003/diff/20001/components/tracing/docs...
components/tracing/docs/memory_infra.md:22: 4. For now, some subsystems only
work if Chrome is started with the
On 2016/01/21 16:58:52, Primiano Tucci wrote:
> I think you want to keep this for a while, as ppl will still need for the
> current stable / beta

Done.

[ssid, 2016-01-25 14:45:08]

The CQ bit was checked by ssid@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-25 14:45:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1584583003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1584583003/40001

[commit-bot: I haz the power, 2016-01-25 14:55:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-25 14:55:11]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[ssid, 2016-01-27 19:38:25]

The CQ bit was checked by ssid@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-27 19:38:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1584583003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1584583003/40001

[commit-bot: I haz the power, 2016-01-27 19:55:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-27 19:55:25]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Primiano Tucci (use gerrit), 2016-01-28 18:37:08]

On 2016/01/27 19:55:25, commit-bot: I haz the power wrote:
> Dry run: Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Right, I think you need to move this change to catapult :)

[ssid, 2016-02-01 11:24:28]

The CQ bit was checked by ssid@chromium.org

[ssid, 2016-02-01 11:24:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
primiano@chromium.org, nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/1584583003/#ps60001
(title: "Remove telemetry/")

[commit-bot: I haz the power, 2016-02-01 11:24:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1584583003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1584583003/60001

[commit-bot: I haz the power, 2016-02-01 13:05:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-01 13:05:45]

Try jobs failed on following builders:
  mac_10_10_perf_bisect on tryserver.chromium.perf (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_10_perf_b...)

[ssid, 2016-02-01 14:32:24]

The CQ bit was checked by ssid@chromium.org

[commit-bot: I haz the power, 2016-02-01 14:33:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1584583003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1584583003/60001

[commit-bot: I haz the power, 2016-02-01 15:52:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-01 15:52:06]

Try jobs failed on following builders:
  mac_10_10_perf_bisect on tryserver.chromium.perf (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_10_perf_b...)

[nednguyen, 2016-02-01 15:59:03]

On 2016/02/01 15:52:06, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   mac_10_10_perf_bisect on tryserver.chromium.perf (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_10_perf_b...)

If the failure looks unrelated, feel free to file a bug about them & remove
"tryserver.chromium.perf:mac_10_10_perf_bisect;" from CQ_EXTRA_TRYBOTS

[ssid, 2016-02-01 16:00:09]

Description was changed from

==========
Remove --no-sandbox flag from command line for telemetry

Now that the browser is able to dump for child processes the
--no-sandbox flag is not required for getting memory statistics. So,
this is removed form the telemetry benchmarks.

BUG=461788
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect
==========

to

==========
Remove --no-sandbox flag from command line for telemetry

Now that the browser is able to dump for child processes the
--no-sandbox flag is not required for getting memory statistics. So,
this is removed form the telemetry benchmarks.

BUG=461788
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:win_perf_bisect
==========

[ssid, 2016-02-01 16:00:17]

The CQ bit was checked by ssid@chromium.org

[commit-bot: I haz the power, 2016-02-01 16:03:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1584583003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1584583003/60001

[commit-bot: I haz the power, 2016-02-01 16:10:02]

Description was changed from

==========
Remove --no-sandbox flag from command line for telemetry

Now that the browser is able to dump for child processes the
--no-sandbox flag is not required for getting memory statistics. So,
this is removed form the telemetry benchmarks.

BUG=461788
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:win_perf_bisect
==========

to

==========
Remove --no-sandbox flag from command line for telemetry

Now that the browser is able to dump for child processes the
--no-sandbox flag is not required for getting memory statistics. So,
this is removed form the telemetry benchmarks.

BUG=461788
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:win_perf_bisect
==========

[commit-bot: I haz the power, 2016-02-01 16:10:04]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-02-01 16:11:01]

Description was changed from

==========
Remove --no-sandbox flag from command line for telemetry

Now that the browser is able to dump for child processes the
--no-sandbox flag is not required for getting memory statistics. So,
this is removed form the telemetry benchmarks.

BUG=461788
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:win_perf_bisect
==========

to

==========
Remove --no-sandbox flag from command line for telemetry

Now that the browser is able to dump for child processes the
--no-sandbox flag is not required for getting memory statistics. So,
this is removed form the telemetry benchmarks.

BUG=461788
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:win_perf_bisect

Committed: https://crrev.com/2bf18cfdfa1b8b0bd829edea2d90277e7e5b0b71
Cr-Commit-Position: refs/heads/master@{#372667}
==========

[commit-bot: I haz the power, 2016-02-01 16:11:01]

Patchset 4 (id:??) landed as
https://crrev.com/2bf18cfdfa1b8b0bd829edea2d90277e7e5b0b71
Cr-Commit-Position: refs/heads/master@{#372667}

[ssid, 2016-02-02 11:47:44]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1659033002/ by ssid@chromium.org.

The reason for reverting is: MemoryInfra benchmarks are failing after this CL.
crbug.com/583101.