GN: Check //content/renderer:* by default.

GN: Check //content/renderer:* by default.

Committed: https://crrev.com/9b51c629bb458562f469c38711be00e42f81b623
Cr-Commit-Position: refs/heads/master@{#370267}

[jbroman, 2016-01-14 14:31:23]

jbroman@chromium.org changed reviewers:
+ brettw@chromium.org

[jbroman, 2016-01-14 14:31:24]

This seems to be enough to make `gn check out/Default //content/renderer:*` pass
on all the trybots.

Not all subdirectories pass (//content/renderer/mus seems to have a circular
dependency), but still it seems useful to check this target.

https://codereview.chromium.org/1584583002/diff/40001/.gn
File .gn (right):

https://codereview.chromium.org/1584583002/diff/40001/.gn#newcode41
.gn:41: "//content/renderer:*",  # Excluding //content/renderer/mus.
//content/renderer/mus has circular dependency issues (it both depends on and is
depended on by the rest of //content/renderer).

https://codereview.chromium.org/1584583002/diff/40001/content/renderer/BUILD.gn
File content/renderer/BUILD.gn (right):

https://codereview.chromium.org/1584583002/diff/40001/content/renderer/BUILD....
content/renderer/BUILD.gn:68: "//sandbox",
used by renderer_main_platform_delegate_{win,android}.cc

https://codereview.chromium.org/1584583002/diff/40001/content/renderer/BUILD....
content/renderer/BUILD.gn:163: "//third_party/libvpx_new",
Used by content/renderer/media/video_track_recorder.cc (included if
enable_webrtc, even if enable_plugins is false).

https://codereview.chromium.org/1584583002/diff/40001/content/renderer/BUILD....
content/renderer/BUILD.gn:242: deps += [ "//ui/ozone" ]
Used by renderer_main.cc.

[brettw, 2016-01-19 23:44:07]

Sweet. LGTM

https://codereview.chromium.org/1584583002/diff/40001/.gn
File .gn (right):

https://codereview.chromium.org/1584583002/diff/40001/.gn#newcode41
.gn:41: "//content/renderer:*",  # Excluding //content/renderer/mus.
On 2016/01/14 14:31:23, jbroman wrote:
> //content/renderer/mus has circular dependency issues (it both depends on and
is
> depended on by the rest of //content/renderer).

You can use the variable "allow_circular_includes_from" to allow this kind of
cycle.

[jbroman, 2016-01-20 00:16:45]

The CQ bit was checked by jbroman@chromium.org

[commit-bot: I haz the power, 2016-01-20 00:20:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1584583002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1584583002/40001

[commit-bot: I haz the power, 2016-01-20 01:42:07]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-20 01:43:27]

Description was changed from

==========
GN: Check //content/renderer:* by default.
==========

to

==========
GN: Check //content/renderer:* by default.

Committed: https://crrev.com/9b51c629bb458562f469c38711be00e42f81b623
Cr-Commit-Position: refs/heads/master@{#370267}
==========

[commit-bot: I haz the power, 2016-01-20 01:43:27]

Patchset 3 (id:??) landed as
https://crrev.com/9b51c629bb458562f469c38711be00e42f81b623
Cr-Commit-Position: refs/heads/master@{#370267}