Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 1584573006: Fix script error on disconnect. (Closed)

Created:
4 years, 11 months ago by kelvinp
Modified:
4 years, 11 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix script error on disconnect. Cause: We set a timer to handle blur event but we do not destroy the timer on dispose. Fix: Wrapped the callback in a base.OneShotTimer and destroyed the timer on dispose. BUG=522577 Committed: https://crrev.com/05db7454a08aeb230f34b1c2ed9fd74252e7c71a Cr-Commit-Position: refs/heads/master@{#369286}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M remoting/webapp/base/js/connected_view.js View 4 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
kelvinp
PTAL
4 years, 11 months ago (2016-01-13 21:41:18 UTC) #3
Jamie
lgtm
4 years, 11 months ago (2016-01-13 21:55:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1584573006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1584573006/20001
4 years, 11 months ago (2016-01-13 22:07:36 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no build URL) android_chromium_gn_compile_dbg on ...
4 years, 11 months ago (2016-01-14 00:15:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1584573006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1584573006/20001
4 years, 11 months ago (2016-01-14 00:22:47 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 11 months ago (2016-01-14 02:23:26 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 02:24:58 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/05db7454a08aeb230f34b1c2ed9fd74252e7c71a
Cr-Commit-Position: refs/heads/master@{#369286}

Powered by Google App Engine
This is Rietveld 408576698