Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 1584563004: Reland of Move BUILD.public to public.bzl. (Closed)

Created:
4 years, 11 months ago by dogben
Modified:
4 years, 11 months ago
Reviewers:
iroth, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Reland of Move BUILD.public to public.bzl. (patchset #1 id:1 of https://codereview.chromium.org/1580923002/ ) Reason for revert: Internal cl/111468120 is now ready to go. Original issue's description: > Revert of Move BUILD.public to public.bzl. (patchset #1 id:1 of https://codereview.chromium.org/1577353002/ ) > > Reason for revert: > Corresponding google-private changes not ready. > > Original issue's description: > > Move BUILD.public to public.bzl. > > > > This allows building with bazel (see http://bazel.io). > > > > BUG=skia: > > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1577353002 > > > > Committed: https://skia.googlesource.com/skia/+/eeebfff54877b24151570c4f02b2299e3f9ef967 > > TBR=benjaminwagner@google.com,mtklein@google.com > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/330043c073de2ee63faa1caa3cb4170da68a79f2 TBR=mtklein@google.com,iroth@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/56f6d0652cb2bbe0d702b325f498f6e11d455bf2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+506 lines, -505 lines) Patch
D BUILD.public View 1 chunk +0 lines, -505 lines 0 comments Download
A public.bzl View 1 chunk +506 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
dogben
Created Reland of Move BUILD.public to public.bzl.
4 years, 11 months ago (2016-01-13 18:45:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1584563004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1584563004/1
4 years, 11 months ago (2016-01-13 18:45:13 UTC) #2
commit-bot: I haz the power
4 years, 11 months ago (2016-01-13 18:45:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/56f6d0652cb2bbe0d702b325f498f6e11d455bf2

Powered by Google App Engine
This is Rietveld 408576698