pkg/compiler/lib/src/cps_ir/scalar_replacement.dart - Issue 1584543002: dart2js cps: Support inlining constructors with type arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/cps_ir/scalar_replacement.dart

Issue 1584543002: dart2js cps: Support inlining constructors with type arguments. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Update status files and unit tests Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/cps_ir/scalar_replacement.dart

diff --git a/pkg/compiler/lib/src/cps_ir/scalar_replacement.dart b/pkg/compiler/lib/src/cps_ir/scalar_replacement.dart

index b220847358fc5c4b8bb4ff19531aeb72b37db05c..cf1e8a8c9a1707cd56f5334c3c7d2d5dba00c6b1 100644

--- a/pkg/compiler/lib/src/cps_ir/scalar_replacement.dart

+++ b/pkg/compiler/lib/src/cps_ir/scalar_replacement.dart

@@ -75,6 +75,7 @@ class ScalarReplacementVisitor extends TrampolineRecursiveVisitor {

// We can do scalar replacement of an aggregate if all uses of an allocation

// are reads or writes.

for (Reference ref = allocation.firstRef; ref != null; ref = ref.next) {

+ // TODO(asgerf): Also handle ReadTypeVariable.

Node use = ref.parent;

if (use is GetField) continue;

if (use is SetField && use.object == ref) continue;