pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart - Issue 1584543002: dart2js cps: Support inlining constructors with type arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart

Issue 1584543002: dart2js cps: Support inlining constructors with type arguments. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Update status files and unit tests Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart

diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart

index e732f3dccee6d415dcb5d4962896cab94a21ee16..f48b1d0fe8653d0b55676b1498c2280a80ba6a14 100644

--- a/pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart

+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart

@@ -301,11 +301,11 @@ class IRTracer extends TracerUtil implements cps_ir.Visitor {

}

visitCreateInstance(cps_ir.CreateInstance node) {

- String className = node.classElement.name;

+ String name = '${node.dartType}';

String arguments = node.arguments.map(formatReference).join(', ');

String typeInformation =

node.typeInformation.map(formatReference).join(', ');

- return 'CreateInstance $className ($arguments) <$typeInformation>';

+ return 'CreateInstance $name ($arguments) <$typeInformation>';

}

visitInterceptor(cps_ir.Interceptor node) {