Issue 158453004: [ABANDONED] [WebSocket] Remove the trailing slash from the origin header.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 158453004: [ABANDONED] [WebSocket] Remove the trailing slash from the origin header. (Closed)

Created:
6 years, 10 months ago by yhirano

Modified:
6 years, 9 months ago

Reviewers:
tyoshino (SeeGerritForStatus), Adam Rice

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

[WebSocket] Remove the trailing slash from the origin header. Currently the WebSocket new impl uses GURL::spec(), but it adds a slash at the end of a origin url. This CL fixes the problem. BUG=339373 R=ricea@chromium.org

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -36 lines)			Patch
	M	net/websockets/websocket_stream.cc	View		2 chunks	+13 lines, -2 lines	0 comments	Download
	M	net/websockets/websocket_stream_test.cc	View		34 chunks	+34 lines, -34 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

tyoshino (SeeGerritForStatus)

6 years, 10 months ago (2014-02-19 05:32:12 UTC) #5

Maybe we should also try to add a new method to GURL that does serialization
conforming to the spec. As GetOrigin() is already used widely, we may need to
add another one, say, GetSerializedOrigin() with some explanation comment.

Expand Messages | Collapse Messages