third_party/WebKit/Source/core/paint/PaintLayer.cpp - Issue 1584493002: Skip PaintPhaseDescendantOutlinesOnly if no descendent outlines in the layer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayer.cpp

Issue 1584493002: Skip PaintPhaseDescendantOutlinesOnly if no descendent outlines in the layer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix multicol span issue Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/multicol/span/outline.html ('K') | « third_party/WebKit/Source/core/paint/PaintLayer.h ('k') | third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/PaintLayer.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintLayer.cpp b/third_party/WebKit/Source/core/paint/PaintLayer.cpp

index df982ee3b772a6d2fc8da5b4bab1e45cf1824700..2267e8cf2c8e54460beb159cab2e77efcc7003db 100644

--- a/third_party/WebKit/Source/core/paint/PaintLayer.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintLayer.cpp

@@ -127,6 +127,7 @@ PaintLayer::PaintLayer(LayoutBoxModelObject* layoutObject, PaintLayerType type)

, m_lostGroupedMapping(false)

, m_needsRepaint(false)

, m_previousPaintResult(PaintLayerPainter::FullyPainted)

+ , m_needsPaintPhaseDescendantOutlines(false)

, m_layoutObject(layoutObject)

, m_parent(0)

, m_previous(0)

@@ -945,6 +946,15 @@ PaintLayer* PaintLayer::enclosingLayerForPaintInvalidation() const

return nullptr;

}

+PaintLayer* PaintLayer::enclosingSelfPaintingLayer() const

+ for (PaintLayer* layer = const_cast<PaintLayer*>(this); layer; layer = layer->parent()) {

+ if (layer->isSelfPaintingLayer())

+ return layer;

+ }

+ return nullptr;

void PaintLayer::setNeedsCompositingInputsUpdate()

{

m_needsAncestorDependentCompositingInputsUpdate = true;