Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutObject.cpp

Issue 1584493002: Skip PaintPhaseDescendantOutlinesOnly if no descendent outlines in the layer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserv ed. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserv ed.
7 * Copyright (C) 2009 Google Inc. All rights reserved. 7 * Copyright (C) 2009 Google Inc. All rights reserved.
8 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 8 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 1388 matching lines...) Expand 10 before | Expand all | Expand 10 after
1399 invalidateDisplayItemClientsWithPaintInvalidationState(paintInvalidation Container, paintInvalidationState, PaintInvalidationSelection); 1399 invalidateDisplayItemClientsWithPaintInvalidationState(paintInvalidation Container, paintInvalidationState, PaintInvalidationSelection);
1400 1400
1401 if (fullInvalidation) 1401 if (fullInvalidation)
1402 return; 1402 return;
1403 1403
1404 fullyInvalidatePaint(paintInvalidationContainer, PaintInvalidationSelection, oldSelectionRect, newSelectionRect); 1404 fullyInvalidatePaint(paintInvalidationContainer, PaintInvalidationSelection, oldSelectionRect, newSelectionRect);
1405 } 1405 }
1406 1406
1407 PaintInvalidationReason LayoutObject::invalidatePaintIfNeeded(PaintInvalidationS tate& paintInvalidationState, const LayoutBoxModelObject& paintInvalidationConta iner) 1407 PaintInvalidationReason LayoutObject::invalidatePaintIfNeeded(PaintInvalidationS tate& paintInvalidationState, const LayoutBoxModelObject& paintInvalidationConta iner)
1408 { 1408 {
1409 if (styleRef().hasOutline()) {
1410 PaintLayer& layer = paintInvalidationState.enclosingSelfPaintingLayer(*t his);
1411 if (layer.layoutObject() != this)
1412 layer.setNeedsPaintPhaseDescendantOutlines();
1413 }
1414
1409 LayoutView* v = view(); 1415 LayoutView* v = view();
1410 if (v->document().printing()) 1416 if (v->document().printing())
1411 return PaintInvalidationNone; // Don't invalidate paints if we're printi ng. 1417 return PaintInvalidationNone; // Don't invalidate paints if we're printi ng.
1412 1418
1413 const LayoutRect oldBounds = previousPaintInvalidationRect(); 1419 const LayoutRect oldBounds = previousPaintInvalidationRect();
1414 const LayoutPoint oldLocation = RuntimeEnabledFeatures::slimmingPaintOffsetC achingEnabled() ? LayoutPoint() : previousPositionFromPaintInvalidationBacking() ; 1420 const LayoutPoint oldLocation = RuntimeEnabledFeatures::slimmingPaintOffsetC achingEnabled() ? LayoutPoint() : previousPositionFromPaintInvalidationBacking() ;
1415 LayoutRect newBounds = boundsRectForPaintInvalidation(paintInvalidationConta iner, &paintInvalidationState); 1421 LayoutRect newBounds = boundsRectForPaintInvalidation(paintInvalidationConta iner, &paintInvalidationState);
1416 LayoutPoint newLocation = RuntimeEnabledFeatures::slimmingPaintOffsetCaching Enabled() ? LayoutPoint() : PaintLayer::positionFromPaintInvalidationBacking(thi s, &paintInvalidationContainer, &paintInvalidationState); 1422 LayoutPoint newLocation = RuntimeEnabledFeatures::slimmingPaintOffsetCaching Enabled() ? LayoutPoint() : PaintLayer::positionFromPaintInvalidationBacking(thi s, &paintInvalidationContainer, &paintInvalidationState);
1417 1423
1418 // Composited scrolling should not be included in the bounds and position tr acking, because the graphics layer backing the scroller 1424 // Composited scrolling should not be included in the bounds and position tr acking, because the graphics layer backing the scroller
(...skipping 2139 matching lines...) Expand 10 before | Expand all | Expand 10 after
3558 const blink::LayoutObject* root = object1; 3564 const blink::LayoutObject* root = object1;
3559 while (root->parent()) 3565 while (root->parent())
3560 root = root->parent(); 3566 root = root->parent();
3561 root->showLayoutTreeAndMark(object1, "*", object2, "-", 0); 3567 root->showLayoutTreeAndMark(object1, "*", object2, "-", 0);
3562 } else { 3568 } else {
3563 fprintf(stderr, "Cannot showLayoutTree. Root is (nil)\n"); 3569 fprintf(stderr, "Cannot showLayoutTree. Root is (nil)\n");
3564 } 3570 }
3565 } 3571 }
3566 3572
3567 #endif 3573 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698