Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp

Issue 1584493002: Skip PaintPhaseDescendantOutlinesOnly if no descendent outlines in the layer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update unit test Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/paint/PaintLayerPainter.h" 5 #include "core/paint/PaintLayerPainter.h"
6 6
7 #include "core/frame/Settings.h" 7 #include "core/frame/Settings.h"
8 #include "core/layout/ClipPathOperation.h" 8 #include "core/layout/ClipPathOperation.h"
9 #include "core/layout/LayoutBlock.h" 9 #include "core/layout/LayoutBlock.h"
10 #include "core/layout/LayoutFrame.h" 10 #include "core/layout/LayoutFrame.h"
(...skipping 656 matching lines...) Expand 10 before | Expand all | Expand 10 after
667 } 667 }
668 668
669 // We have to loop through every fragment multiple times, since we have to i ssue paint invalidations in each specific phase in order for 669 // We have to loop through every fragment multiple times, since we have to i ssue paint invalidations in each specific phase in order for
670 // interleaving of the fragments to work properly. 670 // interleaving of the fragments to work properly.
671 paintForegroundForFragmentsWithPhase(selectionOnly ? PaintPhaseSelection : P aintPhaseDescendantBlockBackgroundsOnly, 671 paintForegroundForFragmentsWithPhase(selectionOnly ? PaintPhaseSelection : P aintPhaseDescendantBlockBackgroundsOnly,
672 layerFragments, context, localPaintingInfo, paintFlags, clipState); 672 layerFragments, context, localPaintingInfo, paintFlags, clipState);
673 673
674 if (!selectionOnly) { 674 if (!selectionOnly) {
675 paintForegroundForFragmentsWithPhase(PaintPhaseFloat, layerFragments, co ntext, localPaintingInfo, paintFlags, clipState); 675 paintForegroundForFragmentsWithPhase(PaintPhaseFloat, layerFragments, co ntext, localPaintingInfo, paintFlags, clipState);
676 paintForegroundForFragmentsWithPhase(PaintPhaseForeground, layerFragment s, context, localPaintingInfo, paintFlags, clipState); 676 paintForegroundForFragmentsWithPhase(PaintPhaseForeground, layerFragment s, context, localPaintingInfo, paintFlags, clipState);
677 paintForegroundForFragmentsWithPhase(PaintPhaseDescendantOutlinesOnly, l ayerFragments, context, localPaintingInfo, paintFlags, clipState); 677 if (m_paintLayer.needsPaintPhaseDescendantOutlines())
678 paintForegroundForFragmentsWithPhase(PaintPhaseDescendantOutlinesOnl y, layerFragments, context, localPaintingInfo, paintFlags, clipState);
678 } 679 }
679 } 680 }
680 681
681 void PaintLayerPainter::paintForegroundForFragmentsWithPhase(PaintPhase phase, 682 void PaintLayerPainter::paintForegroundForFragmentsWithPhase(PaintPhase phase,
682 const PaintLayerFragments& layerFragments, GraphicsContext& context, 683 const PaintLayerFragments& layerFragments, GraphicsContext& context,
683 const PaintLayerPaintingInfo& localPaintingInfo, PaintLayerFlags paintFlags, ClipState clipState) 684 const PaintLayerPaintingInfo& localPaintingInfo, PaintLayerFlags paintFlags, ClipState clipState)
684 { 685 {
685 bool needsScope = layerFragments.size() > 1; 686 bool needsScope = layerFragments.size() > 1;
686 for (auto& fragment : layerFragments) { 687 for (auto& fragment : layerFragments) {
687 if (!fragment.foregroundRect.isEmpty()) { 688 if (!fragment.foregroundRect.isEmpty()) {
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
736 if (!m_paintLayer.containsDirtyOverlayScrollbars()) 737 if (!m_paintLayer.containsDirtyOverlayScrollbars())
737 return; 738 return;
738 739
739 PaintLayerPaintingInfo paintingInfo(&m_paintLayer, LayoutRect(enclosingIntRe ct(damageRect)), paintFlags, LayoutSize()); 740 PaintLayerPaintingInfo paintingInfo(&m_paintLayer, LayoutRect(enclosingIntRe ct(damageRect)), paintFlags, LayoutSize());
740 paintLayer(context, paintingInfo, PaintLayerPaintingOverlayScrollbars); 741 paintLayer(context, paintingInfo, PaintLayerPaintingOverlayScrollbars);
741 742
742 m_paintLayer.setContainsDirtyOverlayScrollbars(false); 743 m_paintLayer.setContainsDirtyOverlayScrollbars(false);
743 } 744 }
744 745
745 } // namespace blink 746 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698