Fix race condition-y Finalize w/ extreme predjudice

Fix race condition-y Finalize w/ extreme predjudice

There's potential a race condition between Finalize and
InitializeWithGUID, if the browser context decides to call Finalize
before GetOrCreateGUID has finished. But Finalize will never actually be
called anyway, nor is it needed, so remove it along with the unused
WebView versions of PostMainMessageLoopRun.

Also fix up threading comments and add some more threading DCHECKs.

BUG=546754
Committed: https://crrev.com/8ff952aee74105ef12bb18075854bceff6327cbf
Cr-Commit-Position: refs/heads/master@{#370431}

[paulmiller, 2016-01-13 20:29:58]

Description was changed from

==========
Fix race condition-y Finalize w/ extreme predjudice

There's potential a race condition between Finalize and
InitializeWithGUID, if the browser context decides to call Finalize
before GetOrCreateGUID has finished. But Finalize will never actually be
called anyway, nor is it needed, so remove it along with the unused
WebView versions of PostMainMessageLoopRun.

Also fix up threading comments and add some more threading DCHECKs.

BUG=546754
==========

to

==========
Fix race condition-y Finalize w/ extreme predjudice

There's potential a race condition between Finalize and
InitializeWithGUID, if the browser context decides to call Finalize
before GetOrCreateGUID has finished. But Finalize will never actually be
called anyway, nor is it needed, so remove it along with the unused
WebView versions of PostMainMessageLoopRun.

Also fix up threading comments and add some more threading DCHECKs.

BUG=546754
==========

[paulmiller, 2016-01-13 20:29:58]

paulmiller@chromium.org changed reviewers:
+ sgurun@chromium.org

[paulmiller, 2016-01-13 20:30:27]

On 2016/01/13 20:29:58, paulmiller wrote:
> mailto:paulmiller@chromium.org changed reviewers:
> + mailto:sgurun@chromium.org

PTAL. This is the follow-up to https://codereview.chromium.org/1563093005/ .

[paulmiller, 2016-01-15 01:27:37]

Patchset #2 (id:20001) has been deleted

[sgurun-gerrit only, 2016-01-20 00:48:12]

lgtm

[paulmiller, 2016-01-20 18:06:04]

The CQ bit was checked by paulmiller@chromium.org

[commit-bot: I haz the power, 2016-01-20 18:06:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1584483004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1584483004/1

[commit-bot: I haz the power, 2016-01-20 18:36:16]

Description was changed from

==========
Fix race condition-y Finalize w/ extreme predjudice

There's potential a race condition between Finalize and
InitializeWithGUID, if the browser context decides to call Finalize
before GetOrCreateGUID has finished. But Finalize will never actually be
called anyway, nor is it needed, so remove it along with the unused
WebView versions of PostMainMessageLoopRun.

Also fix up threading comments and add some more threading DCHECKs.

BUG=546754
==========

to

==========
Fix race condition-y Finalize w/ extreme predjudice

There's potential a race condition between Finalize and
InitializeWithGUID, if the browser context decides to call Finalize
before GetOrCreateGUID has finished. But Finalize will never actually be
called anyway, nor is it needed, so remove it along with the unused
WebView versions of PostMainMessageLoopRun.

Also fix up threading comments and add some more threading DCHECKs.

BUG=546754
==========

[commit-bot: I haz the power, 2016-01-20 18:36:17]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-20 18:37:26]

Description was changed from

==========
Fix race condition-y Finalize w/ extreme predjudice

There's potential a race condition between Finalize and
InitializeWithGUID, if the browser context decides to call Finalize
before GetOrCreateGUID has finished. But Finalize will never actually be
called anyway, nor is it needed, so remove it along with the unused
WebView versions of PostMainMessageLoopRun.

Also fix up threading comments and add some more threading DCHECKs.

BUG=546754
==========

to

==========
Fix race condition-y Finalize w/ extreme predjudice

There's potential a race condition between Finalize and
InitializeWithGUID, if the browser context decides to call Finalize
before GetOrCreateGUID has finished. But Finalize will never actually be
called anyway, nor is it needed, so remove it along with the unused
WebView versions of PostMainMessageLoopRun.

Also fix up threading comments and add some more threading DCHECKs.

BUG=546754

Committed: https://crrev.com/8ff952aee74105ef12bb18075854bceff6327cbf
Cr-Commit-Position: refs/heads/master@{#370431}
==========

[commit-bot: I haz the power, 2016-01-20 18:37:26]

Patchset 1 (id:??) landed as
https://crrev.com/8ff952aee74105ef12bb18075854bceff6327cbf
Cr-Commit-Position: refs/heads/master@{#370431}