chrome/browser/task_management/sampling/task_manager_impl.h - Issue 1584473004: Migrate ProcessesEventRouter to the new task manager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/task_management/sampling/task_manager_impl.h

Issue 1584473004: Migrate ProcessesEventRouter to the new task manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rearrange some code to make it easier to review. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/task_management/providers/web_contents/web_contents_task_provider.cc ('K') | « chrome/browser/task_management/providers/web_contents/web_contents_task_provider.cc ('k') | chrome/browser/task_management/sampling/task_manager_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/task_management/sampling/task_manager_impl.h

diff --git a/chrome/browser/task_management/sampling/task_manager_impl.h b/chrome/browser/task_management/sampling/task_manager_impl.h

index 562b8dcadef093171068f360e9bc0a9d0d3483b7..ddbfead63b93a67bfd2d0f04ac8d3523fa10a623 100644

--- a/chrome/browser/task_management/sampling/task_manager_impl.h

+++ b/chrome/browser/task_management/sampling/task_manager_impl.h

@@ -59,6 +59,11 @@ class TaskManagerImpl :

const base::ProcessHandle& GetProcessHandle(TaskId task_id) const override;

const base::ProcessId& GetProcessId(TaskId task_id) const override;

Task::Type GetType(TaskId task_id) const override;

+ int GetTabId(TaskId task_id) const override;

+ int GetChildProcessUniqueId(TaskId task_id) const override;

+ void GetTerminationStatus(TaskId task_id,

+ base::TerminationStatus* out_status,

+ int* out_error_code) const override;

int64_t GetNetworkUsage(TaskId task_id) const override;

int64_t GetProcessTotalNetworkUsage(TaskId task_id) const override;

int64_t GetSqliteMemoryUsed(TaskId task_id) const override;

@@ -69,11 +74,13 @@ class TaskManagerImpl :

TaskId task_id,

blink::WebCache::ResourceTypeStats* stats) const override;

const TaskIdList& GetTaskIdsList() const override;

+ TaskIdList GetIdsOfTasksSharingSameProcess(TaskId task_id) const override;

size_t GetNumberOfTasksOnSameProcess(TaskId task_id) const override;

// task_management::TaskProviderObserver:

void TaskAdded(Task* task) override;

void TaskRemoved(Task* task) override;

+ void TaskUnresponsive(Task* task) override;

// content::GpuDataManagerObserver:

void OnVideoMemoryUsageStatsUpdate(