Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Side by Side Diff: chrome/browser/extensions/api/processes/processes_apitest.cc

Issue 1584473004: Migrate ProcessesEventRouter to the new task manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rearrange some code to make it easier to review. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "chrome/browser/extensions/api/processes/processes_api.h"
6 #include "chrome/browser/extensions/extension_apitest.h" 7 #include "chrome/browser/extensions/extension_apitest.h"
7 #include "chrome/browser/task_manager/task_manager.h"
8 #include "chrome/browser/task_manager/task_manager_browsertest_util.h" 8 #include "chrome/browser/task_manager/task_manager_browsertest_util.h"
9 #include "chrome/browser/ui/browser.h" 9 #include "chrome/browser/ui/browser.h"
10 #include "chrome/browser/ui/browser_dialogs.h" 10 #include "chrome/browser/ui/browser_dialogs.h"
11 #include "chrome/browser/ui/browser_window.h" 11 #include "chrome/browser/ui/browser_window.h"
12 #include "extensions/common/switches.h" 12 #include "extensions/common/switches.h"
13 #include "extensions/test/extension_test_message_listener.h" 13 #include "extensions/test/extension_test_message_listener.h"
14 14
15 class ProccessesApiTest : public ExtensionApiTest {
ncarter (slow) 2016/02/11 22:16:49 Proccesses -> Processes
afakhry 2016/02/17 02:27:14 Done. :)
16 public:
17 ProccessesApiTest() {}
18 ~ProccessesApiTest() override {}
19
20 int GetListenersCount() {
21 return extensions::ProcessesAPI::Get(profile())->
22 processes_event_router()->listeners_;
23 }
24
25 private:
26 DISALLOW_COPY_AND_ASSIGN(ProccessesApiTest);
27 };
28
15 // Test is flaky: http://crbug.com/346990 29 // Test is flaky: http://crbug.com/346990
16 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, DISABLED_Processes) { 30 IN_PROC_BROWSER_TEST_F(ProccessesApiTest, Processes) {
17 ASSERT_TRUE(RunExtensionTest("processes/api")) << message_; 31 ASSERT_TRUE(RunExtensionTest("processes/api")) << message_;
18 } 32 }
19 33
20 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, ProcessesVsTaskManager) { 34 IN_PROC_BROWSER_TEST_F(ProccessesApiTest, ProcessesApiListeners) {
21 // This test is for the old implementation of the task manager. We must 35 EXPECT_EQ(0, GetListenersCount());
22 // explicitly disable the new one.
23 task_manager::browsertest_util::EnableOldTaskManager();
24
25 // Ensure task manager is not yet updating
26 TaskManagerModel* model = TaskManager::GetInstance()->model();
27 EXPECT_EQ(0, model->update_requests_);
28 EXPECT_EQ(TaskManagerModel::IDLE, model->update_state_);
29 36
30 // Load extension that adds listener in background page 37 // Load extension that adds listener in background page
31 ExtensionTestMessageListener listener("ready", false); 38 ExtensionTestMessageListener listener("ready", false);
32 ASSERT_TRUE(LoadExtension( 39 ASSERT_TRUE(LoadExtension(
33 test_data_dir_.AppendASCII("processes").AppendASCII("onupdated"))); 40 test_data_dir_.AppendASCII("processes").AppendASCII("onupdated")));
34 ASSERT_TRUE(listener.WaitUntilSatisfied()); 41 ASSERT_TRUE(listener.WaitUntilSatisfied());
35 42
36 // Ensure the task manager has started updating 43 // Ensure the listeners count has changed.
37 EXPECT_EQ(1, model->update_requests_); 44 EXPECT_EQ(1, GetListenersCount());
38 EXPECT_EQ(TaskManagerModel::TASK_PENDING, model->update_state_);
39
40 // Now show the task manager and wait for it to be ready
41 chrome::ShowTaskManager(browser());
42
43 EXPECT_EQ(2, model->update_requests_);
44 EXPECT_EQ(TaskManagerModel::TASK_PENDING, model->update_state_);
45 45
46 // Unload the extension and check that listener count decreases 46 // Unload the extension and check that listener count decreases
47 UnloadExtension(last_loaded_extension_id()); 47 UnloadExtension(last_loaded_extension_id());
48 EXPECT_EQ(1, model->update_requests_); 48
49 EXPECT_EQ(0, GetListenersCount());
49 } 50 }
50 51
51 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, CannotTerminateBrowserProcess) { 52 IN_PROC_BROWSER_TEST_F(ProccessesApiTest, CannotTerminateBrowserProcess) {
52 ASSERT_TRUE(RunExtensionTest("processes/terminate-browser-process")) 53 ASSERT_TRUE(RunExtensionTest("processes/terminate-browser-process"))
53 << message_; 54 << message_;
54 } 55 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698