Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1584463004:
History: add --enable-grouped-history to about:flags (Closed)
DescriptionHistory: expose --enable-grouped-history on about:flags
This flag already existed, just wasn't on about:flags.
Hopefully this allows folks (i.e. designers, i.e. bettes@) to more
easily see and play with this UI without needing a supervised user.
R=tsergeant@chromium.org
BUG=425625
Committed: https://crrev.com/57ffd45da3c115a65163167fa6615b38262bea61
Cr-Commit-Position: refs/heads/master@{#369266}
Patch Set 1 #Patch Set 2 : histograms.xml #Patch Set 3 : asdf #Patch Set 4 : git cl try #
Messages
Total messages: 26 (15 generated)
Description was changed from ========== History: add --enable-grouped-history to about:flags This is so folks (i.e. designers, i.e. bettes@) can more easily see and play with this UI without needing a supervised user. R=tsergeant@chromium.org BUG=425625 ========== to ========== History: expose --enable-grouped-history on about:flags This flag already existed, just wasn't on about:flags. This is so folks (i.e. designers, i.e. bettes@) can more easily see and play with this UI without needing a supervised user. R=tsergeant@chromium.org BUG=425625 ==========
Description was changed from ========== History: expose --enable-grouped-history on about:flags This flag already existed, just wasn't on about:flags. This is so folks (i.e. designers, i.e. bettes@) can more easily see and play with this UI without needing a supervised user. R=tsergeant@chromium.org BUG=425625 ========== to ========== History: expose --enable-grouped-history on about:flags This flag already existed, just wasn't on about:flags. Hopefully this allows folks (i.e. designers, i.e. bettes@) to more easily see and play with this UI without needing a supervised user. R=tsergeant@chromium.org BUG=425625 ==========
Description was changed from ========== History: expose --enable-grouped-history on about:flags This flag already existed, just wasn't on about:flags. Hopefully this allows folks (i.e. designers, i.e. bettes@) to more easily see and play with this UI without needing a supervised user. R=tsergeant@chromium.org BUG=425625 ========== to ========== History: expose --enable-grouped-history on about:flags This flag already existed, just wasn't on about:flags. Hopefully this allows folks (i.e. designers, i.e. bettes@) to more easily see and play with this UI without needing a supervised user. R=tsergeant@chromium.org BUG=425625 ==========
Description was changed from ========== History: expose --enable-grouped-history on about:flags This flag already existed, just wasn't on about:flags. Hopefully this allows folks (i.e. designers, i.e. bettes@) to more easily see and play with this UI without needing a supervised user. R=tsergeant@chromium.org BUG=425625 ========== to ========== History: expose --enable-grouped-history on about:flags This flag already existed, just wasn't on about:flags. Hopefully this allows folks (i.e. designers, i.e. bettes@) to more easily see and play with this UI without needing a supervised user. R=tsergeant@chromium.org BUG=425625 ==========
Description was changed from ========== History: expose --enable-grouped-history on about:flags This flag already existed, just wasn't on about:flags. Hopefully this allows folks (i.e. designers, i.e. bettes@) to more easily see and play with this UI without needing a supervised user. R=tsergeant@chromium.org BUG=425625 ========== to ========== History: expose --enable-grouped-history on about:flags This flag already existed, just wasn't on about:flags. Hopefully this allows folks (i.e. designers, i.e. bettes@) to more easily see and play with this UI without needing a supervised user. R=tsergeant@chromium.org BUG=425625 ==========
lgtm
The CQ bit was checked by dbeam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1584463004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1584463004/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by dbeam@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tsergeant@chromium.org Link to the patchset: https://codereview.chromium.org/1584463004/#ps60001 (title: "git cl try")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1584463004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1584463004/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
dbeam@chromium.org changed reviewers: + rkaplow@chromium.org
+rkaplow@ for tools/metrics/histograms/histograms.xml stamp
asvitkine@chromium.org changed reviewers: + asvitkine@chromium.org
lgtm
The CQ bit was checked by dbeam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1584463004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1584463004/60001
Message was sent while issue was closed.
Description was changed from ========== History: expose --enable-grouped-history on about:flags This flag already existed, just wasn't on about:flags. Hopefully this allows folks (i.e. designers, i.e. bettes@) to more easily see and play with this UI without needing a supervised user. R=tsergeant@chromium.org BUG=425625 ========== to ========== History: expose --enable-grouped-history on about:flags This flag already existed, just wasn't on about:flags. Hopefully this allows folks (i.e. designers, i.e. bettes@) to more easily see and play with this UI without needing a supervised user. R=tsergeant@chromium.org BUG=425625 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== History: expose --enable-grouped-history on about:flags This flag already existed, just wasn't on about:flags. Hopefully this allows folks (i.e. designers, i.e. bettes@) to more easily see and play with this UI without needing a supervised user. R=tsergeant@chromium.org BUG=425625 ========== to ========== History: expose --enable-grouped-history on about:flags This flag already existed, just wasn't on about:flags. Hopefully this allows folks (i.e. designers, i.e. bettes@) to more easily see and play with this UI without needing a supervised user. R=tsergeant@chromium.org BUG=425625 Committed: https://crrev.com/57ffd45da3c115a65163167fa6615b38262bea61 Cr-Commit-Position: refs/heads/master@{#369266} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/57ffd45da3c115a65163167fa6615b38262bea61 Cr-Commit-Position: refs/heads/master@{#369266} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
