runtime/vm/virtual_memory.h - Issue 1584443002: VM: Precompiled rodata snapshot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/virtual_memory.h

Issue 1584443002: VM: Precompiled rodata snapshot. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: added read-only page type Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/virtual_memory.h

diff --git a/runtime/vm/virtual_memory.h b/runtime/vm/virtual_memory.h

index 53ba57df510288a2e0dc4bcc75ae73cd4eac9137..270d3cf8f763c4b268f09a2a714e142ee4943532 100644

--- a/runtime/vm/virtual_memory.h

+++ b/runtime/vm/virtual_memory.h

@@ -71,7 +71,7 @@ class VirtualMemory {

bool embedder_allocated() const { return embedder_allocated_; }

- static VirtualMemory* ForInstructionsSnapshot(void* pointer, uword size);

+ static VirtualMemory* ForExternalPage(void* pointer, uword size);

private:

static VirtualMemory* ReserveInternal(intptr_t size);