Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/object.cc

Issue 1584443002: VM: Precompiled rodata snapshot. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: added read-only page type Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/isolate.cc ('k') | runtime/vm/pages.h » ('j') | runtime/vm/raw_object_snapshot.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.cc
diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc
index f67ade566f075fa6a6f7fa31eb9b0eee835bc6c0..51b71f605234b63419ce04c89279d5776db3e8de 100644
--- a/runtime/vm/object.cc
+++ b/runtime/vm/object.cc
@@ -915,9 +915,12 @@ class PremarkingVisitor : public ObjectVisitor {
if (!obj->IsFreeListElement()) {
ASSERT(obj->IsVMHeapObject());
if (obj->IsMarked()) {
- // Precompiled instructions are loaded pre-marked.
+ // Precompiled objects are loaded pre-marked.
ASSERT(Dart::IsRunningPrecompiledCode());
- ASSERT(obj->IsInstructions());
+ ASSERT(obj->IsInstructions() ||
+ obj->IsPcDescriptors() ||
+ obj->IsStackmap() ||
+ obj->IsOneByteString());
} else {
obj->SetMarkBitUnsynchronized();
}
« no previous file with comments | « runtime/vm/isolate.cc ('k') | runtime/vm/pages.h » ('j') | runtime/vm/raw_object_snapshot.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698