runtime/bin/gen_snapshot.cc - Issue 1584443002: VM: Precompiled rodata snapshot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/gen_snapshot.cc

Issue 1584443002: VM: Precompiled rodata snapshot. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: added read-only page type Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/bin/gen_snapshot.cc

diff --git a/runtime/bin/gen_snapshot.cc b/runtime/bin/gen_snapshot.cc

index af2bdb70bfb3c062a8c4e07c9c6a80752e633448..f1f7e2ccce523dceb6c378e32ff682cbe7ece425 100644

--- a/runtime/bin/gen_snapshot.cc

+++ b/runtime/bin/gen_snapshot.cc

@@ -1032,6 +1032,7 @@ int main(int argc, char** argv) {

char* error = Dart_Initialize(

NULL,

+ NULL,

CreateServiceIsolate,

NULL,