Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1584433002:
Delete MockVideoRenderer::SetSize. (Closed)
|
Created:
4 years, 11 months ago by nisse-chromium (ooo August 14) Modified:
4 years, 11 months ago Reviewers:
perkj_chrome CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDelete MockVideoRenderer::SetSize.
BUG=webrtc:5426
Committed: https://crrev.com/b5e7b4126e67f6a881907392ed55a805563d50ee
Cr-Commit-Position: refs/heads/master@{#369120}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Deleted width and height too. #
Messages
Total messages: 20 (10 generated)
Description was changed from ========== Delete MockVideoRenderer::SetSize. BUG=webrtc:5426 ========== to ========== Delete MockVideoRenderer::SetSize. BUG=webrtc:5426 ==========
nisse@chromium.org changed reviewers: + perkj@chromium.org
The CQ bit was checked by nisse@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1584433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1584433002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
lgtm with the comments below addressed. https://codereview.chromium.org/1584433002/diff/1/content/renderer/media/webr... File content/renderer/media/webrtc/mock_peer_connection_dependency_factory.cc (left): https://codereview.chromium.org/1584433002/diff/1/content/renderer/media/webr... content/renderer/media/webrtc/mock_peer_connection_dependency_factory.cc:168: width_ = width; please also remove width_ and height and their access methods.
https://codereview.chromium.org/1584433002/diff/1/content/renderer/media/webr... File content/renderer/media/webrtc/mock_peer_connection_dependency_factory.cc (left): https://codereview.chromium.org/1584433002/diff/1/content/renderer/media/webr... content/renderer/media/webrtc/mock_peer_connection_dependency_factory.cc:168: width_ = width; On 2016/01/12 17:02:33, perkj_chrome wrote: > please also remove width_ and height and their access methods. Done. I thought they were used, but I mixed it up with the MockRtcVideoCapturer.
The CQ bit was checked by nisse@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1584433002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1584433002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by nisse@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from perkj@chromium.org Link to the patchset: https://codereview.chromium.org/1584433002/#ps20001 (title: "Deleted width and height too.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1584433002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1584433002/20001
Message was sent while issue was closed.
Description was changed from ========== Delete MockVideoRenderer::SetSize. BUG=webrtc:5426 ========== to ========== Delete MockVideoRenderer::SetSize. BUG=webrtc:5426 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Delete MockVideoRenderer::SetSize. BUG=webrtc:5426 ========== to ========== Delete MockVideoRenderer::SetSize. BUG=webrtc:5426 Committed: https://crrev.com/b5e7b4126e67f6a881907392ed55a805563d50ee Cr-Commit-Position: refs/heads/master@{#369120} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/b5e7b4126e67f6a881907392ed55a805563d50ee Cr-Commit-Position: refs/heads/master@{#369120} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
