Fix newline normalization in _PhysicalFile.readAsStringSync().

Fix newline normalization in _PhysicalFile.readAsStringSync().

Most clients of _PhysicalFile read the file by translating it into a
Source object using createSource() and then reading it using
FileBasedSource.contentsFromFile, which normalizes newlines using
FileBasedSource.fileReadMode.

However, a few clients read the file directly using
_PhysicalFile.readAsStringSync(), which wasn't doing the
normalization.  This CL adds the normalization to that code path.

One such client was the code generation logic for summaries; this
caused code generation to produce different results on Windows, which
led to a test failure.

Fixes #25470.

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/3dcef185d65c5bbe98162624ef4ddc49571702e2

[Paul Berry, 2016-01-15 20:48:18]

paulberry@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2016-01-15 20:51:47]

LGTM

[Paul Berry, 2016-01-15 20:54:25]

Description was changed from

==========
Fix newline normalization in _PhysicalFile.readAsStringSync().

Most clients of _PhysicalFile read the file by translating it into a
Source object using createSource() and then reading it using
FileBasedSource.contentsFromFile, which normalizes newlines using
FileBasedSource.fileReadMode.

However, a few clients read the file directly using
_PhysicalFile.readAsStringSync(), which wasn't doing the
normalization.  This CL adds the normalization to that code path.

One such client was the code generation logic for summaries; this
caused code generation to produce different results on Windows, which
led to a test failure.

Fixes #25470.
==========

to

==========
Fix newline normalization in _PhysicalFile.readAsStringSync().

Most clients of _PhysicalFile read the file by translating it into a
Source object using createSource() and then reading it using
FileBasedSource.contentsFromFile, which normalizes newlines using
FileBasedSource.fileReadMode.

However, a few clients read the file directly using
_PhysicalFile.readAsStringSync(), which wasn't doing the
normalization.  This CL adds the normalization to that code path.

One such client was the code generation logic for summaries; this
caused code generation to produce different results on Windows, which
led to a test failure.

Fixes #25470.

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/3dcef185d65c5bbe98162624ef4ddc49571702e2
==========

[Paul Berry, 2016-01-15 20:54:26]

Committed patchset #1 (id:1) manually as
3dcef185d65c5bbe98162624ef4ddc49571702e2 (presubmit successful).