Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1584313003: Oilpan: fix build after r369477. (Closed)

Created:
4 years, 11 months ago by sof
Modified:
4 years, 11 months ago
Reviewers:
oilpan-reviews, huangs
CC:
chromium-reviews, blink-reviews, kinuko+watch, oshima, samuong, vasilii
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: fix build after r369477. TBR=oilpan-reviews BUG=485650 NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/Source/platform/scroll/Scrollbar.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scroll/Scrollbar.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
huangs
I've reverted http://crrev.com/1560403002/ with http://crrev.com/1586983004/, and now oilpan compile works. Please ping when you're ready ...
4 years, 11 months ago (2016-01-14 19:34:07 UTC) #3
huangs
4 years, 11 months ago (2016-01-14 19:35:00 UTC) #5
huangs
4 years, 11 months ago (2016-01-14 19:47:13 UTC) #6
Committing known non-compiling code seems like a bad idea.  After chatting with
oshima@, we decided to let him resubmit his original patch through CQ, combined
with your fix.

Many thanks for finding the solution!

Powered by Google App Engine
This is Rietveld 408576698