Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issue 1584303002: [crankshaft] Don't inline array indexOf operations if receiver's proto is not a JSObject. (Closed)

Created:
4 years, 11 months ago by Igor Sheludko
Modified:
4 years, 11 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Don't inline array indexOf operations if receiver's proto is not a JSObject. BUG=chromium:577112 LOG=N Committed: https://crrev.com/1bb7cfda7f062dc62ef2d7e98116a0328d31b966 Cr-Commit-Position: refs/heads/master@{#33320}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M src/crankshaft/hydrogen.cc View 1 chunk +1 line, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-577112.js View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1584303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1584303002/1
4 years, 11 months ago (2016-01-14 18:41:05 UTC) #2
Igor Sheludko
PTAL
4 years, 11 months ago (2016-01-14 18:41:10 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-14 19:17:47 UTC) #6
Jakob Kummerow
lgtm
4 years, 11 months ago (2016-01-15 10:11:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1584303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1584303002/1
4 years, 11 months ago (2016-01-15 10:18:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-15 10:19:16 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-15 10:20:10 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1bb7cfda7f062dc62ef2d7e98116a0328d31b966
Cr-Commit-Position: refs/heads/master@{#33320}

Powered by Google App Engine
This is Rietveld 408576698