Add UMA histograms for WebUSB.

Add UMA histograms for WebUSB.

This change adds UMA histogram metrics to track user interactions with
the UI surfaces introduced by WebUSB. We record the,

 * disposition of the device detected notification,
 * disposition of the device chooser, and
 * revoked permissions.

BUG=556845
Committed: https://crrev.com/43b45a5cfd7f6bff93236e1c4088f83cf2832072
Cr-Commit-Position: refs/heads/master@{#370785}

[Reilly Grant (use Gerrit), 2016-01-15 00:57:24]

Description was changed from

==========
Add UMA histograms for WebUSB.

This change adds UMA histogram metrics to track user interactions with
the UI surfaces introduced by WebUSB. We record the,

 * disposition of the device detected notification,
 * disposition of the device chooser, and
 * revoked permissions.

BUG=556845
==========

to

==========
Add UMA histograms for WebUSB.

This change adds UMA histogram metrics to track user interactions with
the UI surfaces introduced by WebUSB. We record the,

 * disposition of the device detected notification,
 * disposition of the device chooser, and
 * revoked permissions.

BUG=556845
==========

[Reilly Grant (use Gerrit), 2016-01-15 00:57:25]

reillyg@chromium.org changed reviewers:
+ asvitkine@chromium.org, juncai@chromium.org

[Reilly Grant (use Gerrit), 2016-01-15 00:57:52]

reillyg@chromium.org changed reviewers:
+ rockot@chromium.org
- juncai@chromium.org

[Reilly Grant (use Gerrit), 2016-01-15 00:58:30]

asvitkine@chromium.org for histograms.xml.
rockot@chromium.org for everything else.

[Alexei Svitkine (slow), 2016-01-18 20:05:13]

https://codereview.chromium.org/1584283003/diff/1/chrome/browser/usb/usb_choo...
File chrome/browser/usb/usb_chooser_bubble_delegate.cc (right):

https://codereview.chromium.org/1584283003/diff/1/chrome/browser/usb/usb_choo...
chrome/browser/usb/usb_chooser_bubble_delegate.cc:127:
WEBUSB_CHOOSER_CLOSED_EPHEMERAL_PERMISSION_GRANTED,
Nit: Each histogram macro expands to a lot of code. Can you make a helper
function for this that just takes the enum as a param?

https://codereview.chromium.org/1584283003/diff/1/chrome/browser/usb/usb_choo...
File chrome/browser/usb/usb_chooser_context.cc (right):

https://codereview.chromium.org/1584283003/diff/1/chrome/browser/usb/usb_choo...
chrome/browser/usb/usb_chooser_context.cc:130:
WEBUSB_PERMISSION_REVOKED_EPHEMERAL,
Ditto.

[Reilly Grant (use Gerrit), 2016-01-20 00:59:37]

https://codereview.chromium.org/1584283003/diff/1/chrome/browser/usb/usb_choo...
File chrome/browser/usb/usb_chooser_bubble_delegate.cc (right):

https://codereview.chromium.org/1584283003/diff/1/chrome/browser/usb/usb_choo...
chrome/browser/usb/usb_chooser_bubble_delegate.cc:127:
WEBUSB_CHOOSER_CLOSED_EPHEMERAL_PERMISSION_GRANTED,
On 2016/01/18 20:05:13, Alexei Svitkine (slow) wrote:
> Nit: Each histogram macro expands to a lot of code. Can you make a helper
> function for this that just takes the enum as a param?

Done.

https://codereview.chromium.org/1584283003/diff/1/chrome/browser/usb/usb_choo...
File chrome/browser/usb/usb_chooser_context.cc (right):

https://codereview.chromium.org/1584283003/diff/1/chrome/browser/usb/usb_choo...
chrome/browser/usb/usb_chooser_context.cc:130:
WEBUSB_PERMISSION_REVOKED_EPHEMERAL,
On 2016/01/18 20:05:13, Alexei Svitkine (slow) wrote:
> Ditto.

Done.

[Alexei Svitkine (slow), 2016-01-21 15:46:44]

lgtm

[Reilly Grant (use Gerrit), 2016-01-21 18:43:35]

reillyg@chromium.org changed reviewers:
+ asargent@chromium.org
- rockot@chromium.org

[Reilly Grant (use Gerrit), 2016-01-21 18:43:56]

Hey Antony, since we talked about these histograms can you take a look at this
patch adding them?

[asargent_no_longer_on_chrome, 2016-01-21 18:54:15]

lgtm with a couple small things

https://codereview.chromium.org/1584283003/diff/20001/chrome/browser/chrome_w...
File chrome/browser/chrome_webusb_browser_client.cc (right):

https://codereview.chromium.org/1584283003/diff/20001/chrome/browser/chrome_w...
chrome/browser/chrome_webusb_browser_client.cc:34: enum WebUsbNotificationClosed
{
nit: We typically include a comment above enums used in histograms warning
people not to remove/reorder/renumber items in them; it would be good to do so
here. (You can search around the extensions system for similar comments and crib
their form or whatever)

(same comment applies to new enums in other files in the CL)

https://codereview.chromium.org/1584283003/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1584283003/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:80763: +  <int value="1" label="Closed
by user"/>
It might be good to provide an explanation for the distinction between "Closed"
and "Closed by user" as it's not immediately obvious from their names. I can't
recall off the top of my head if enum's support explanatory comments, but if
they don't you could just add something to the <summary> block for
WebUsb.NotificationClosed

[Reilly Grant (use Gerrit), 2016-01-21 19:27:18]

The CQ bit was checked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2016-01-21 19:27:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
asvitkine@chromium.org, asargent@chromium.org
Link to the patchset: https://codereview.chromium.org/1584283003/#ps40001
(title: "Update comments.")

[commit-bot: I haz the power, 2016-01-21 19:27:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1584283003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1584283003/40001

[commit-bot: I haz the power, 2016-01-21 21:05:04]

Description was changed from

==========
Add UMA histograms for WebUSB.

This change adds UMA histogram metrics to track user interactions with
the UI surfaces introduced by WebUSB. We record the,

 * disposition of the device detected notification,
 * disposition of the device chooser, and
 * revoked permissions.

BUG=556845
==========

to

==========
Add UMA histograms for WebUSB.

This change adds UMA histogram metrics to track user interactions with
the UI surfaces introduced by WebUSB. We record the,

 * disposition of the device detected notification,
 * disposition of the device chooser, and
 * revoked permissions.

BUG=556845
==========

[commit-bot: I haz the power, 2016-01-21 21:05:05]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-21 21:07:03]

Description was changed from

==========
Add UMA histograms for WebUSB.

This change adds UMA histogram metrics to track user interactions with
the UI surfaces introduced by WebUSB. We record the,

 * disposition of the device detected notification,
 * disposition of the device chooser, and
 * revoked permissions.

BUG=556845
==========

to

==========
Add UMA histograms for WebUSB.

This change adds UMA histogram metrics to track user interactions with
the UI surfaces introduced by WebUSB. We record the,

 * disposition of the device detected notification,
 * disposition of the device chooser, and
 * revoked permissions.

BUG=556845

Committed: https://crrev.com/43b45a5cfd7f6bff93236e1c4088f83cf2832072
Cr-Commit-Position: refs/heads/master@{#370785}
==========

[commit-bot: I haz the power, 2016-01-21 21:07:04]

Patchset 3 (id:??) landed as
https://crrev.com/43b45a5cfd7f6bff93236e1c4088f83cf2832072
Cr-Commit-Position: refs/heads/master@{#370785}