Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: pkg/compiler/lib/src/tree_ir/optimization/statement_rewriter.dart

Issue 1584253003: dart2js cps: Fix traversal order in statement rewriter. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/tree_ir/optimization/statement_rewriter.dart
diff --git a/pkg/compiler/lib/src/tree_ir/optimization/statement_rewriter.dart b/pkg/compiler/lib/src/tree_ir/optimization/statement_rewriter.dart
index f23533ccfbd76f55a87656df2921e21a360ed9b0..1c96301711577753d98346431fcc4e8fb7d3cc06 100644
--- a/pkg/compiler/lib/src/tree_ir/optimization/statement_rewriter.dart
+++ b/pkg/compiler/lib/src/tree_ir/optimization/statement_rewriter.dart
@@ -579,13 +579,11 @@ class StatementRewriter extends Transformer implements Pass {
}
Expression visitLogicalOperator(LogicalOperator node) {
- node.left = visitExpression(node.left);
-
// Impure expressions may not propagate across the branch.
inEmptyEnvironment(() {
node.right = visitExpression(node.right);
});
-
+ node.left = visitExpression(node.left);
return node;
}
@@ -1244,8 +1242,8 @@ class StatementRewriter extends Transformer implements Pass {
@override
Statement visitYield(Yield node) {
- node.input = visitExpression(node.input);
node.next = visitStatement(node.next);
+ node.input = visitExpression(node.input);
return node;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698